This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Update link as current Devdoc Magento version #4297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Krish TechnoLabs
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
ronak2ram
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
Hello @magesanjay
Thanks for your contribution.
As per review. You did a two URL change.
For v2.1
{{ site.gdeurl }} to {{ site.gdeurl21 }}
For v2.2
{{ site.gdeurl }} to {{ site.gdeurl22 }}
For v2.3
{{ site.gdeurl }} to {{ site.gdeurl23 }}
|
@magesanjay, are there any differences between each version of the If there is no difference between version 2.1, 2.2, or 2.3, then we should leave the symlinks and replace the For example:
AND
|
jeff-matthews
added
2.1.x
2.2.x
2.3.x
|
@jeff-matthews, No there is not any other changes between each version. |
|
Perfect! Thanks @magesanjay. |
jeff-matthews
approved these changes
Apr 19, 2019
|
running tests |
|
Link checking failed: |
jeff-matthews
suggested changes
Apr 22, 2019
Slash Added in URL Co-Authored-By: magesanjay <[email protected]>
Co-Authored-By: magesanjay <[email protected]>
|
@jeff-matthews I have added suggestion. |
|
running tests |
|
Link checking failed again: |
jeff-matthews
suggested changes
Apr 22, 2019
|
@jeff-matthews I have corrected url paths. |
|
running tests |
|
Tests are still failing |
|
Hi @jeff-matthews i have updated link now. |
|
running tests |
jeff-matthews
approved these changes
Apr 22, 2019
|
Hi @magesanjay, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, it will Update link as per current magento version of devdoc.
Below are the lines which have updated links on text "JavaScript component" and "accordion".
JavaScript componentin .phtml page templates.accordionwidget is intiialized on the [data-role=example] element as illustration)Additional information
List all affected URLs