This repository was archived by the owner on Nov 19, 2024. It is now read-only.
magento/devdocs#: Resolvers. Add a tip about input/output types #4331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
rogyar
suggested changes
Apr 24, 2019
rogyar
approved these changes
Apr 24, 2019
rogyar
added
the
Technical
keharper
suggested changes
Jun 10, 2019
| @@ -68,6 +68,32 @@ Syntax option | Description | |||
| `@resolver(class)` | The class of the resolver | |||
| `@doc(description)` | Describes the purpose of the mutation | |||
|
|
|||
| {:.bs-callout .bs-callout-tip} | |||
| It's a good practice to define a separate types for input/output data. It bring additional extension points, so every input/output type can be extended by adding additional fields to the definition. | |||
There was a problem hiding this comment.
Suggested change
| It's a good practice to define a separate types for input/output data. It bring additional extension points, so every input/output type can be extended by adding additional fields to the definition. | |
| It is a good practice to define separate types for input and output data. This practice permits additional extension points, so every input and output type can be extended by adding additional fields to the definition. |
There was a problem hiding this comment.
fixed
Thank you, @keharper 👍
Merge remote-tracking branch 'upstream/master' into Resolvers-Input-Output
…ter/devdocs into Resolvers-Input-Output
keharper
approved these changes
Jun 25, 2019
|
running tests |
|
Hi @atwixfirster, thank you for your contribution! |
|
Thanks @atwixfirster ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR adds a tip about resolver input/output types.
Affected URLs
Thank you!