Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

GraphQL: Add isEmailAvailable query #4556

Merged
merged 3 commits into from
May 20, 2019
Merged

GraphQL: Add isEmailAvailable query #4556

merged 3 commits into from
May 20, 2019

Conversation

keharper
Copy link
Contributor

@keharper keharper commented May 18, 2019 •
edited by dshevtsov
Loading

Purpose of this pull request

This pull request (PR) adds the isEmailAvailable query.

Affected DevDocs pages

Links to Magento source code

whatsnew
Added the isEmailAvailable query to the GraphQL customer endpoint.

@keharper keharper added Major Update Significant original updates to existing content Internal Dev Differentiates work between community and Magento staff Community Docs impacted by community code contribution xx2.3.2 Magento 2.3.2 changes labels May 18, 2019
@keharper keharper self-assigned this May 18, 2019
@keharper keharper requested a review from erikmarr May 18, 2019 17:34
@keharper keharper mentioned this pull request May 18, 2019
Merged
@osrecio osrecio self-assigned this May 19, 2019
osrecio
osrecio approved these changes May 19, 2019
View reviewed changes
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the baseCode and I tested with the documentation and works perfectly.

erikmarr
erikmarr approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question could be completely off-base so feel free to ignore.

guides/v2.3/graphql/reference/customer.md Outdated

The `customer` query returns information about the logged-in customer.

The `isEmailAvailable` query checks whether the specified email has already been used to create a customer account. A value of `true` indicates the customer can use the email address to create an account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Does a value of true indicate that the email has NOT already been used and can therefore be used to create an account?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's implied, but do you feel we should explicitly mention that the email has not already been used?

guides/v2.3/graphql/reference/customer.md Outdated

Attribute | Data Type | Description
--- | --- | ---
`is_email_available` | Boolean | A value of `true` indicates the email address can be used to create an account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on my above question, this might need some rewriting. A value of true indicates the email address is available to use to create an account....or something like that.

erikmarr
erikmarr approved these changes May 20, 2019
View reviewed changes
guides/v2.3/graphql/reference/customer.md Outdated

The `customer` query returns information about the logged-in customer.

The `isEmailAvailable` query checks whether the specified email has already been used to create a customer account. A value of `true` indicates the customer can use the email address to create an account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's implied, but do you feel we should explicitly mention that the email has not already been used?

keharper
keharper commented May 20, 2019
View reviewed changes
keharper
keharper commented May 20, 2019
View reviewed changes
@keharper keharper merged commit d298425 into develop May 20, 2019
@ghost
Copy link

ghost commented May 20, 2019

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper deleted the kh_graphql-isEmailAvailable branch June 17, 2019 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@osrecio osrecio osrecio approved these changes

@erikmarr erikmarr erikmarr approved these changes

Assignees

@osrecio osrecio

@keharper keharper

Labels
Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content xx2.3.2 Magento 2.3.2 changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keharper @osrecio @erikmarr