Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add GraphQL vault documentation #4760

Merged
merged 3 commits into from
Jun 17, 2019
Merged

Add GraphQL vault documentation #4760

merged 3 commits into from
Jun 17, 2019

Conversation

keharper
Copy link
Contributor

@keharper keharper commented Jun 14, 2019

Purpose of this pull request

This pull request (PR) documents the query and mutation added in magento/graphql-ce#307

Affected DevDocs pages

whatsnew
GraphQL supports the Vault endpoint, which allows customers to store payment information with a service such as Braintree Vault.

@keharper keharper added Internal Dev Differentiates work between community and Magento staff Community Docs impacted by community code contribution New Topic A major update published as an entirely new document xx2.3.2 Magento 2.3.2 changes labels Jun 14, 2019
@keharper keharper requested a review from erikmarr June 14, 2019 20:37
@keharper keharper self-assigned this Jun 14, 2019
Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some clarifying questions.


Attribute | Data Type | Description
--- | --- | ---
`items` | [PaymentToken] | Contains an array of customer payment tokens
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between a "customer payment token" and "customer payment method"? Payment method makes more sense to me. Can we use that throughout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't change the terminology. Tokens are managed here, not payment methods.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikmarr , payment token and method are different. The payment token - tokenized on Payment Gateway credit card, payment method - an integration to provide a possibility to make a payment transaction, there are no terms like "customer payment method" because the payment method doesn't belong to any customer.

--- | --- | ---
`details` | String | Stored account details
`payment_method_code` | String | The payment method code associated with the token
`public_hash` | String | The public hash of the token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention this is automatically generated like an auth token or customer cart ID? Maybe that's only necessary if we add a mutation to add payment token.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned that the vault provider generates the token

@keharper keharper requested a review from YevSent June 14, 2019 21:17

Attribute | Data Type | Description
--- | --- | ---
`items` | [PaymentToken] | Contains an array of customer payment tokens
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikmarr , payment token and method are different. The payment token - tokenized on Payment Gateway credit card, payment method - an integration to provide a possibility to make a payment transaction, there are no terms like "customer payment method" because the payment method doesn't belong to any customer.


## Query

The `customerPaymentTokens` query returns an array of stored payment methods.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"payment token" is not equal to "payment method"

@keharper keharper merged commit 7961a44 into develop Jun 17, 2019
@ghost
Copy link

ghost commented Jun 17, 2019

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper deleted the kh_graphql-vault branch June 17, 2019 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document xx2.3.2 Magento 2.3.2 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants