-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some clarifying questions.
|
||
Attribute | Data Type | Description | ||
--- | --- | --- | ||
`items` | [PaymentToken] | Contains an array of customer payment tokens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between a "customer payment token" and "customer payment method"? Payment method makes more sense to me. Can we use that throughout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't change the terminology. Tokens are managed here, not payment methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikmarr , payment token and method are different. The payment token - tokenized on Payment Gateway credit card, payment method - an integration to provide a possibility to make a payment transaction, there are no terms like "customer payment method" because the payment method doesn't belong to any customer.
--- | --- | --- | ||
`details` | String | Stored account details | ||
`payment_method_code` | String | The payment method code associated with the token | ||
`public_hash` | String | The public hash of the token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention this is automatically generated like an auth token or customer cart ID? Maybe that's only necessary if we add a mutation to add payment token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned that the vault provider generates the token
|
||
Attribute | Data Type | Description | ||
--- | --- | --- | ||
`items` | [PaymentToken] | Contains an array of customer payment tokens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikmarr , payment token and method are different. The payment token - tokenized on Payment Gateway credit card, payment method - an integration to provide a possibility to make a payment transaction, there are no terms like "customer payment method" because the payment method doesn't belong to any customer.
|
||
## Query | ||
|
||
The `customerPaymentTokens` query returns an array of stored payment methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"payment token" is not equal to "payment method"
Hi @keharper, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) documents the query and mutation added in magento/graphql-ce#307
Affected DevDocs pages
whatsnew
GraphQL supports the Vault endpoint, which allows customers to store payment information with a service such as Braintree Vault.