Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Described missed prompt widget options and added code samples of prompt widget initialization#4782

Merged
dobooth merged 3 commits intomagento:masterfrom
serhiyzhovnir:prompt-widget-documentation-adjustments
Jun 19, 2019
Merged

Described missed prompt widget options and added code samples of prompt widget initialization#4782
dobooth merged 3 commits intomagento:masterfrom
serhiyzhovnir:prompt-widget-documentation-adjustments

Conversation

@serhiyzhovnir
Copy link
Copy Markdown
Contributor

@serhiyzhovnir serhiyzhovnir commented Jun 19, 2019

@devops-devdocs
Copy link
Copy Markdown
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Jun 19, 2019
@rogyar rogyar added 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content labels Jun 19, 2019
Copy link
Copy Markdown
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not capitalize the "Admin" word. In this case, we don't describe a product name or a personal name. Thank you.
https://github.com/magento/devdocs/pull/4782/files#diff-4671b33861390321846f924cf04f205eR15

@rogyar
Copy link
Copy Markdown
Contributor

rogyar commented Jun 19, 2019

Please, do not capitalize the "Admin" word. In this case, we don't describe a product name or a personal name. Thank you.
https://github.com/magento/devdocs/pull/4782/files#diff-4671b33861390321846f924cf04f205eR15

Nevermind. I've just noticed that this change is from the previous version. Thank you

@dobooth
Copy link
Copy Markdown
Contributor

dobooth commented Jun 19, 2019

running tests

@dobooth dobooth merged commit 171fe19 into magento:master Jun 19, 2019
@ghost
Copy link
Copy Markdown

ghost commented Jun 19, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12
Copy link
Copy Markdown
Contributor

meker12 commented Jun 20, 2019

@dobooth Please add the whatsnew info to the PR description. Thx.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants