Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/graphql-ce#: Magento CLI. Support short commands name #4908

Merged
merged 8 commits into from
Jul 12, 2019

Conversation

atwixfirster
Copy link
Contributor

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Jul 9, 2019
@rogyar rogyar added 2.2.x 2.3.x Magento 2.3 related changes labels Jul 9, 2019
@jeff-matthews jeff-matthews added the Technical Updates to the code or processes that alter the technical content of the doc label Jul 11, 2019
@jeff-matthews jeff-matthews requested a review from dshevtsov July 11, 2019 14:32
@dshevtsov dshevtsov self-assigned this Jul 11, 2019
Copy link
Collaborator

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical: If we are telling readers that some commands are available using shortcuts, it makes sense to provide a full list of all available shortcuts. This topic is generated from the output of the bin/magento list command, so it would be great to have those shortcuts in the generated list as well that requires changing the Magento CLI itself.
Otherwise, we can confuse people providing information that the shortcuts are available, but they should guess about available options.

I'd suggest to contribute to the magento/magento2 codebase creating a feature request or even a PR.

Editorial:

  1. Notes should be tagged with {: .bs-callout-info } class.
  2. Consider using Google Developer Documentation Style Guide in cases when the DevDocs Style Guide doesn't give clear guidelines:

@atwixfirster
Copy link
Contributor Author

Thank you, for your review @dshevtsov .

Technical: If we are telling readers that some commands are available using shortcuts, it makes sense to provide a full list of all available shortcuts.

Honestly, I thought about that. However, for example, for the bin/magento setup:upgrade command there are a lot of shortcuts combinations:

  • bin/magento s:up
  • bin/magento s:upg
  • bin/magento s:upgr
  • bin/magento s:upgra
  • bin/magento s:upgrad
  • bin/magento se:up
  • bin/magento se:upg
  • bin/magento se:upgr
  • bin/magento se:upgra
  • bin/magento se:upgrad
  • bin/magento set:up
  • bin/magento set:upg
  • bin/magento set:upgr
  • bin/magento set:upgra
  • bin/magento set:upgrad
  • bin/magento setu:up
  • bin/magento setu:upg
  • bin/magento setu:upgr
  • bin/magento setu:upgra
  • bin/magento setu:upgrad
  • bin/magento setup:up
  • bin/magento setup:upg
  • bin/magento setup:upgr
  • bin/magento setup:upgra
  • bin/magento setup:upgrad

All of them are the bin/magento setup:upgrade shortcuts. Let's imagine if we add all this stuff into DevDocs tutorial.....

Editorial:

  1. Notes should be tagged with {: .bs-callout-info } class.

done

Politeness and use of "please"

fixed

Consider changing via to using. Refer to https://developers.google.com/style/word-list#letter-V

removed

Thank you!

@dshevtsov
Copy link
Collaborator

I see your point @atwixfirster. Seems like this is a Symphony feature.
Then, we should merely add to the note a link to the Symphony documentation that should be enough for general understanding of how to use shortcuts with any Magento CLI command.

@atwixfirster
Copy link
Contributor Author

Then, we should merely add to the note a link to the Symphony documentation that should be enough for general understanding of how to use shortcuts with any Magento CLI command.

added

Thank you, @dshevtsov

@dshevtsov dshevtsov self-requested a review July 11, 2019 21:56
@dshevtsov dshevtsov requested a review from erikmarr July 11, 2019 21:56
Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor wording suggestion.

@@ -10,6 +10,9 @@
This reference contains {{ commands | size }} commands available through the `bin/magento` command-line tool.
The initial list is auto generated using `bin/magento list` command at the {{ site.data.var.ce }} edition.

{: .bs-callout-info }
Magento CLI allows a short command name instead of a full one. For example, `bin/magento setup:upgrade` can be called using `bin/magento s:up`, `bin/magento s:upg`, etc. See [shortcut syntax](https://symfony.com/doc/current/components/console/usage.html#shortcut-syntax) to understand how to use shortcuts with any Magento CLI command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Magento CLI allows a short command name instead of a full one. For example, `bin/magento setup:upgrade` can be called using `bin/magento s:up`, `bin/magento s:upg`, etc. See [shortcut syntax](https://symfony.com/doc/current/components/console/usage.html#shortcut-syntax) to understand how to use shortcuts with any Magento CLI command.
You can call Magento CLI commands using shortcuts instead of the full command name. For example, you can call `bin/magento setup:upgrade` using `bin/magento s:up`, `bin/magento s:upg`, etc. See [shortcut syntax](https://symfony.com/doc/current/components/console/usage.html#shortcut-syntax) to understand how to use shortcuts with any Magento CLI command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Thank you, @erikmarr

@dshevtsov
Copy link
Collaborator

running tests

@dshevtsov dshevtsov merged commit ac98239 into magento:master Jul 12, 2019
@ghost
Copy link

ghost commented Jul 12, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12
Copy link
Contributor

meker12 commented Jul 15, 2019

@dshevstov and @erikmarr Just confirming that you don't want to call this update out in What's New.

@dshevtsov
Copy link
Collaborator

@meker12, no.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants