Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Migrating Customer endpoint to new directories as per Magedoc3973 #5124

Merged
merged 16 commits into from
Aug 27, 2019

Conversation

erikmarr
Copy link
Contributor

@erikmarr erikmarr commented Aug 5, 2019

Purpose of this pull request

This pull request (PR) moves the customer endpoint to the new queries/mutations subdirs.

Affected DevDocs pages

@erikmarr erikmarr added Site Improvements Updates to tools, processes, and site architecture that improve reader and contributor experience Internal Dev Differentiates work between community and Magento staff xx2.3.3 Magento 2.3.3 changes labels Aug 5, 2019
@erikmarr erikmarr self-assigned this Aug 5, 2019
@erikmarr erikmarr requested a review from keharper August 5, 2019 22:10
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first pass-through without looking at a build. I'll look at the PR holistically next time.

```graphql
mutation {
changeCustomerPassword(
currentPassword: "[email protected]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
currentPassword: "[email protected]",
currentPassword: "[email protected]"

mutation {
updateCustomerAddress(id:3, input: {
city: "New City"
postcode: "5555"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
postcode: "5555"
postcode: "55555"

"updateCustomerAddress": {
"id": 3,
"city": "New City",
"postcode": 5555
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"postcode": 5555
"postcode": 55555


The `isEmailAvailable` query checks whether the specified email has already been used to create a customer account. A value of `true` indicates the email address is available, and the customer can use the email address to create an account.

To return or modify information about a customer, Magento recommends you use customer tokens in the header of your GraphQL calls. However, you also can use [session authentication]({{ page.baseurl }}/get-started/authentication/gs-authentication-session.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safe to not include this paragraph, because the query is checking whether a specific emall address has been used before.

Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing the Output attributes section for almost all of the mutations. I stopped making individual comments when I noticed that.

@erikmarr
Copy link
Contributor Author

running tests

1 similar comment
@erikmarr
Copy link
Contributor Author

running tests

@erikmarr
Copy link
Contributor Author

running tests

@erikmarr erikmarr merged commit 24818b0 into develop Aug 27, 2019
@ghost
Copy link

ghost commented Aug 27, 2019

Hi @erikmarr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@erikmarr erikmarr deleted the em_magedoc-3973 branch August 27, 2019 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internal Dev Differentiates work between community and Magento staff Site Improvements Updates to tools, processes, and site architecture that improve reader and contributor experience xx2.3.3 Magento 2.3.3 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants