Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Removed legacy Cloud infrastructure info #5125

Merged
merged 8 commits into from
Aug 22, 2019

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Aug 6, 2019

Purpose of this pull request

Update Cloud documentation to remove legacy infrastructure references and instructions:

  • Remove references to projects provisioned before October 23, 2017
  • Remove "submit support ticket" references for environment config changes on Pro Staging and Production environments
  • Remove Pro Architecture (legacy) topic
  • Remove instructions for migrating projects from legacy infrastructure in Add Staging and Production to Pro Project UI topic
  • Remove references to deleted topics, and add redirects as needed
  • Clean up markdown syntax

Validation

  • Build preview
  • Verify that instructions and references to legacy Cloud projects and project configurations have been removed
  • Editorial review

Affected DevDocs pages

whatsnew
Updated Magento Commerce Cloud Guide to remove obsolete instructions for configuring legacy environments and migrating legacy Cloud environments to use the Project Web UI. Legacy environments are those provisioned prior to October 23, 2017.

@meker12 meker12 self-assigned this Aug 6, 2019
@meker12 meker12 added Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content and removed Progress: review labels Aug 6, 2019
@meker12 meker12 added the 2.x label Aug 6, 2019
@meker12 meker12 requested a review from hguthrie August 6, 2019 03:19
@meker12 meker12 marked this pull request as ready for review August 6, 2019 03:33
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleans up a lot, and we need this. But this is a lot to review because I think that you creeped in scope many times. I understand the temptation; these improvements help greatly, but still a lot to review! In the spirit of your cleansing, I added a couple of quick suggestions to clear some command steps.

* For Starter, we recommend you create a `staging` branch from Master, then branch from `staging` for development.
* For Pro, you want to branch from Development (Integration `master`).
- For Starter, we recommend you create a `staging` branch from Master, then branch from `staging` for development.
- For Pro, you want to branch from the development branch (Integration `master`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- For Pro, you want to branch from the development branch (Integration `master`).
- For Pro, create a development branch from the Integration environment.

- `magento-cloud user:add` adds a user to the project
- `magento-cloud user:delete` deletes a user
- `magento-cloud user:list [users]` lists project users
- `magento-cloud user:role` views or change a user's role

For example, the following command adds the project administrator (`admin`) role to `[email protected]` and gives her `contributor` privileges to the `development` environment:

The following prompts are displayed:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following prompts are displayed:


* **Staging and Production environments in the UI for Pro projects**. Starting October 23, 2017, all projects created using the free 30-day trial or provisioned for new accounts includes Staging and Production environments in the Project Web Interface. Existing accounts created before October 23, 2017 can enter a ticket to be updated. For more information, see [Add Staging and Production to Pro projects UI]({{ site.baseurl }}/guides/v2.2/cloud/trouble/pro-env-management.html).
* **Staging and Production environments in the UI for Pro projects**. Starting October 23, 2017, all projects created using the free 30-day trial or provisioned for new accounts includes Staging and Production environments in the Project Web Interface. See
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See is left open-ended...

@meker12 meker12 requested a review from skotasthane August 6, 2019 17:14
url: /cloud/architecture/pro-architecture-legacy.html

- label: Add Staging and Production to Pro projects UI
url: /cloud/trouble/pro-env-management.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still links to this topic in the whatsnew topic. It will likely fail link checking. Should this redirect somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Added a redirect to the Pro develop and deploy workflow topic.


### Migrate your `.magento.app.yaml` file {#pro-yaml}

**Important:** If you have **not modified** the default deployment hooks or configurations, skip this step and continue with [Get your Pro access URLs](#pro-urls). Only migrate the file if you modified the deployment hooks or added configuration updates.
{:.bs-callout-important}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The important class doesn't exist. You can use info, warning, or tip.

@meker12 meker12 dismissed hguthrie’s stale review August 22, 2019 14:58

Made the requested change, but the reviewer is on vacation. Can make further updates to content on a separate PR as needed.

@meker12
Copy link
Contributor Author

meker12 commented Aug 22, 2019

running tests

@meker12 meker12 merged commit 2627f1e into master Aug 22, 2019
@ghost
Copy link

ghost commented Aug 22, 2019

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 deleted the mae-MAGECLOUD-3462-remove-legacy-info branch August 22, 2019 23:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants