This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Update XSS prevention guide #5143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include latest best practices, fix misleading Escaper methods cases. Keep only 1 XSS guide
|
An admin must run tests on this PR before it can be merged. |
|
https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/templates/template-security.html page must either be removed or redirect to https://devdocs.magento.com/guides/v2.3/extension-dev-guide/xss-protection.html so we would only have one anti-XSS guide to support |
dobooth
added
2.2.x
2.3.x
jcalcaben
approved these changes
Aug 26, 2019
|
@jcalcaben, is this ready to test and merge? |
|
yes, I plan on processing this the next chance I get |
|
running tests |
|
running tests |
|
Hi @AlexMaxHorkun, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) will update invalid use cases for PHTML escaping, provide guidance on XSS prevention in other areas but .phtml templates
Affected DevDocs pages
Links to Magento source code
whatsnew
Updated the XSS Prevention Strategy topic to correct invalid use cases for PHTML escaping and provide guidance on XSS prevention in other areas.