This repository was archived by the owner on Nov 19, 2024. It is now read-only.
magento/devdocs#: Plugins (Interceptors). Add plugin method naming convention. #5200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
atwixfirster
changed the title
rogyar
added
2.2.x
2.3.x
rogyar
approved these changes
Aug 18, 2019
There was a problem hiding this comment.
Hi @atwixfirster. Thank you for extending the documentation. The part about interceptors naming was really missing.
jeff-matthews
removed
the
Technical
jeff-matthews
suggested changes
Aug 26, 2019
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
jeff-matthews
suggested changes
Aug 27, 2019
There was a problem hiding this comment.
Thanks for making those changes @atwixfirster!
There are also some markdown syntax errors that need to be fixed:
rake test:cicd
Testing Markdown style with mdl ...
guides/v2.2/extension-dev-guide/plugins.md:60: MD009 Trailing spaces
guides/v2.2/extension-dev-guide/plugins.md:62: MD009 Trailing spaces
guides/v2.2/extension-dev-guide/plugins.md:64: MD009 Trailing spaces
guides/v2.2/extension-dev-guide/plugins.md:76: MD009 Trailing spaces
guides/v2.2/extension-dev-guide/plugins.md:78: MD009 Trailing spaces
guides/v2.2/extension-dev-guide/plugins.md:80: MD009 Trailing spaces
guides/v2.2/extension-dev-guide/plugins.md:81: MD009 Trailing spaces
guides/v2.2/extension-dev-guide/plugins.md:93: MD009 Trailing spaces
guides/v2.2/extension-dev-guide/plugins.md:94: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/plugins.md:60: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/plugins.md:62: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/plugins.md:64: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/plugins.md:76: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/plugins.md:78: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/plugins.md:80: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/plugins.md:81: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/plugins.md:93: MD009 Trailing spaces
guides/v2.3/extension-dev-guide/plugins.md:94: MD009 Trailing spaces
A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md
The Markdown linter has found 20 issues```
|
fixed @jeff-matthews, could you please run tests again? Thank you! |
|
Thanks @atwixfirster, but there are still errors: |
|
missed up with that line 😊 fixed Thanks, @jeff-matthews |
jeff-matthews
approved these changes
Aug 27, 2019
|
running tests |
|
Hi @atwixfirster, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds "Plugin method naming convention" section to Plugins (Interceptors) page.
Affected DevDocs pages
Links to Magento source code
Thank you!
whatsnew
Added a Plugin method naming convention section to Plugins (Interceptors) topic.