-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added the documentation for multiselect widget #5207
Added the documentation for multiselect widget #5207
Conversation
An admin must run tests on this PR before it can be merged. |
Hi @serhiyzhovnir. As always, thank you for the great topic! |
Hi @rogyar |
Awesome, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new topic @serhiyzhovnir! I made a few editorial suggestions.
@jeff-matthews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serhiyzhovnir, I just noticed some markdown syntax errors on your branch that will fail tests. Please fix the following issues so I can finish processing your PR:
rake test:cicd
Testing Markdown style with mdl ...
guides/v2.2/javascript-dev-guide/widgets/widget-multiselect.md:35: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/widgets/widget-multiselect.md:35: MD009 Trailing spaces
A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md
The Markdown linter has found 4 issues
Hi @jeff-matthews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. Thanks @serhiyzhovnir!
running tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serhiyzhovnir, tests are failing on broke links:
Running ["LinkChecker::DoubleSlashCheck", "HtmlCheck", "ImageCheck", "LinkCheck", "ScriptCheck"] on ["_site"] on *.html...
Ran on 2809 files!
- linking to internal hash #updateDelay that does not exist
* _site/guides/v2.2/javascript-dev-guide/widgets/widget-multiselect.html (line 275)
<a href="#updateDelay">updateDelay</a>
* _site/guides/v2.3/javascript-dev-guide/widgets/widget-multiselect.html (line 275)
<a href="#updateDelay">updateDelay</a>
rake aborted!
HTML-Proofer found 2 failures!```
Hi @jeff-matthews |
running tests |
Hi @serhiyzhovnir, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) adds documentation about the Multiselect widget.
Affected DevDocs pages
This documentation will have the following links:
Page look:

Links to Magento source code
whatsnew
Added a new topic about the Multiselect widget.