-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Updated What's New for documentation updates since Aug 9, 2019 #5212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comments:
- Run
rake preview
locally to test HTML - Test all new links manually by clicking each link
See my comments at the changed files.
_data/whats-new.yml
Outdated
type: Major update | ||
date: August 13, 2019 | ||
link: https://github.com/magento/devdocs/pull/5161 | ||
- description: Added documentation for the [TrimInput widget](https://devdocs.magento.com//guides/v2.3/javascript-dev-guide/widgets/widget_trim-input.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link https://devdocs.magento.com//guides
causes double slash failure when I generate a preview with rake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is redirected to home page. There is no such file guides/v2.3/javascript-dev-guide/widgets/widget_trim-input.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dshevtsov Did you refresh? I don't have the *.md file in the files that I generated. Nor do I have a double slash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't mean you have .md files in links.
The link points to the HTML page, but the page does not exist, because there is no corresponding .md file in the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying.
_data/whats-new.yml
Outdated
type: New topic | ||
date: August 13, 2019 | ||
link: https://github.com/magento/devdocs/pull/5135 | ||
- description: Added an optional step to the [Cloud Docker]( https://devdocs.magento.com/guides/v2.3/cloud/docker/docker-config.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the link starts from a space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dshevtsov The space is added when the entry is generated from the What's New script. I don't see why because the comment in the PR looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you open the PR description in raw format, you'll see the issue.
GitHub UI resolves the issue with spaces, but our tool uses GitHub API and gets raw Markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple comments.
date: August 15, 2019 | ||
link: https://github.com/magento/devdocs/pull/5123 | ||
- description: Added the [Change increment ID for a database entity on particular | ||
store](http://devdocs.magento.com/guides/v2.2/config-guide/multi-site/change-increment-id.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not critical, but the link should point to the topic from latest version.
date: August 14, 2019 | ||
link: https://github.com/magento/devdocs/pull/5182 | ||
- description: Provided details about what happens when you run the [Data Migration | ||
Tool](https://devdocs.magento.com/guides/v2.2/migration/migration-migrate-data.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not critical, but the link should point to the topic from latest version.
running tests |
Hi @meker12, thank you for your contribution! |
Purpose of this pull request
This pull request updates the What's New page with the documentation changes published since the last update on August 9.
Affected DevDocs pages