This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Adding and additional section of how to move a checkout component #5225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
osrecio
approved these changes
Aug 23, 2019
jeff-matthews
added
Major Update
jeff-matthews
suggested changes
Aug 23, 2019
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
|
Hey @jeff-matthews thank you for the suggestions, could you please check the latest updates? |
keharper
reviewed
Aug 24, 2019
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
|
@keharper the changes were updated. |
keharper
approved these changes
Aug 25, 2019
jeff-matthews
approved these changes
Aug 26, 2019
m2-community-project
bot
added
Progress: approved
Progress: acceptance testing
and removed
Progress: review
Progress: approved
labels
jeff-matthews
suggested changes
Aug 26, 2019
There was a problem hiding this comment.
@eduard13, I just noticed some markdown syntax errors on your branch that will fail tests. Please fix the following issues so that I can finish processing your PR:
rake test:cicd
Testing Markdown style with mdl ...
guides/v2.2/howdoi/checkout/checkout_customize.md:99: MD009 Trailing spaces
guides/v2.2/howdoi/checkout/checkout_customize.md:137: MD009 Trailing spaces
guides/v2.3/howdoi/checkout/checkout_customize.md:99: MD009 Trailing spaces
guides/v2.3/howdoi/checkout/checkout_customize.md:137: MD009 Trailing spaces
A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md
The Markdown linter has found 6 issues```
|
@jeff-matthews, have just removed them. Thank you for informing. |
jeff-matthews
approved these changes
Aug 26, 2019
|
running tests |
|
Hi @eduard13, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds an additional section to Customize Checkout page, by showing how to move components within the page.
Affected DevDocs pages
Links to Magento source code
whatsnew
Added new code examples to the Customize Checkout tutorial.