-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added documentation about the Breadcrumbs widget #5228
Added documentation about the Breadcrumbs widget #5228
Conversation
An admin must run tests on this PR before it can be merged. |
Hi @rogyar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new topic @serhiyzhovnir! I made a few editorial suggestions.
Hi @jeff-matthews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serhiyzhovnir, I just noticed some markdown syntax errors in your branch that will fail tests. Please fix the following issues so I can finish processing your PR.
rake test:cicd
Testing Markdown style with mdl ...
guides/v2.2/javascript-dev-guide/widgets/widget-breadcrumbs.md:39: MD009 Trailing spaces
guides/v2.2/javascript-dev-guide/widgets/widget-breadcrumbs.md:51: MD009 Trailing spaces
guides/v2.2/javascript-dev-guide/widgets/widget-breadcrumbs.md:130: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/widgets/widget-breadcrumbs.md:39: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/widgets/widget-breadcrumbs.md:51: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/widgets/widget-breadcrumbs.md:130: MD009 Trailing spaces
A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md
The Markdown linter has found 8 issues```
Hi @jeff-matthews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. Thanks @serhiyzhovnir.
running tests |
1 similar comment
running tests |
running tests |
@serhiyzhovnir, tests are failing on links:
|
@jeff-matthews the issue with the link is fixed. |
running tests |
Hi @serhiyzhovnir, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) adds the documentation about the Breadcrumbs widget.
Affected DevDocs pages
This documentation will have the following links:
Page Look
Links to Magento source code
whatsnew
Added a new topic about the Breadcrumbs widget.