Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Adjusted Loader widget documentation #5230

Merged

Conversation

serhiyzhovnir
Copy link
Contributor

@serhiyzhovnir serhiyzhovnir commented Aug 21, 2019

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar added Major Update Significant original updates to existing content 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels Aug 21, 2019
Co-Authored-By: Yaroslav Rogoza <[email protected]>
@serhiyzhovnir
Copy link
Contributor Author

@rogyar The requested changes were added.
Thank you!

@rogyar
Copy link
Contributor

rogyar commented Aug 22, 2019

Hi @serhiyzhovnir. Please, take a look at the conflicts with the mainline.
Thank you

@serhiyzhovnir
Copy link
Contributor Author

Hi @rogyar
The conflict is resolved.
Thank you!

@jeff-matthews jeff-matthews removed the Technical Updates to the code or processes that alter the technical content of the doc label Aug 23, 2019
@serhiyzhovnir
Copy link
Contributor Author

Hi @jeff-matthews
The required changes were added.
Please, check the PR.
Thank you!

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @serhiyzhovnir!

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews
Copy link
Contributor

Tests failed due to markdown style rule violations. @serhiyzhovnir, please fix the following issues:

+ rake test:cicd
�[35mTesting Markdown style with mdl ...�[0m
�[31mThe Markdown linter has found 8 issues�[0m
�[33mguides/v2.2/javascript-dev-guide/widgets/widget_loader.md:9: MD009 Trailing spaces
guides/v2.2/javascript-dev-guide/widgets/widget_loader.md:50: MD009 Trailing spaces
guides/v2.2/javascript-dev-guide/widgets/widget_loader.md:58: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/widgets/widget_loader.md:9: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/widgets/widget_loader.md:50: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/widgets/widget_loader.md:58: MD009 Trailing spaces

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown linting failed

@serhiyzhovnir
Copy link
Contributor Author

Hi @jeff-matthews
We have fixed the issue with failed markdown linting.
Please, check it.
Thank you!

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews
Copy link
Contributor

@serhiyzhovnir, tests failed on image link:

Running ["LinkChecker::DoubleSlashCheck", "HtmlCheck", "ImageCheck", "LinkCheck", "ScriptCheck"] on ["_site"] on *.html... 


Ran on 2803 files!


- internal image /common/images/widget/loader-widget-result.png does not exist
  *  _site/guides/v2.2/javascript-dev-guide/widgets/widget_loader.html (line 424)
  *  _site/guides/v2.3/javascript-dev-guide/widgets/widget_loader.html (line 424)
rake aborted!
HTML-Proofer found 2 failures!``` 

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix broken link to image

@serhiyzhovnir
Copy link
Contributor Author

@jeff-matthews
I've added the missed image.
Thank you!

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit 7b89085 into magento:master Aug 26, 2019
@ghost
Copy link

ghost commented Aug 26, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants