This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added Note for 404 error regarding /robots.txt files #5255
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
20b9d50
Added note for 404 errors
hickskenh faba5a1
Merge branch 'master' into ken-gh5237-robot-errors
hickskenh 2da31df
updated code language
hickskenh 5514e0d
Merge branch 'ken-gh5237-robot-errors' of https://github.com/magento/…
hickskenh 099a73f
changed column name to ital instead of code
hickskenh eb87b33
Merge branch 'master' into ken-gh5237-robot-errors
hickskenh 9f66b20
changed "change" to "remove" per Anthony chico
hickskenh b63dd3e
Merge branch 'master' into ken-gh5237-robot-errors
hickskenh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume italicizing UI areas you don't click on is a cloud style thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when doing a search for "menu,", i found other references to menus (Marketing x3, Extension x2, Content x2, Account x2). Marketing and Content have the ital formatting, Account and Extension do not.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the style in Cloud, but I know that it is not consistently applied. In this topic, it is consistent. I think that it is potentially confusing not to have any formatting on UI element titles that are mentioned in the text of a procedure step.
Looking at our style guide, it seems that the only formatting we apply to UI elements is bold. When I first started, I remember reading about using italics to reference UI element names, but I don't see that anywhere now.
Checking out the Google style guide, they bold all UI element mentions whether they are referenced by title, or referenced as a clickable element. https://developers.google.com/style/ui-elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been much discussion about what to do here. It's ongoing... I just wish we were consisten across repos/doc sets!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving menu titles in ital for this topic