Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Replacing the layout existing plugin with a proper one #5547

Merged
merged 4 commits into from
Oct 21, 2019
Merged

Replacing the layout existing plugin with a proper one #5547

merged 4 commits into from
Oct 21, 2019

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Oct 2, 2019 •
edited by meker12
Loading

Purpose of this pull request

This pull request (PR) replaces the not related layout plugin with a proper one. The existing plugin explains how to use plugins, but doesn't not have anything related to layout customization.

Even more, we have a separate topic that describes the plugins:
https://devdocs.magento.com/guides/v2.2/extension-dev-guide/plugins.html

Affected DevDocs pages

Links to Magento source code

whatsnew
Updated the Plugins (Interceptors) topic in the Frontend Developer Guide to clarify that these plugins are for updating layouts. Also, removed incorrect information and clarified descriptions and examples.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar
Copy link
Contributor

rogyar commented Oct 2, 2019

Hi @eduard13, that's a very good catch, thank you. I believe this part should describe using plugins from the layout customization perspective rather than using plugins in general. Especially considering the fact that we have separate documentation about the general usage of plugins.

@rogyar rogyar added 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc Major Update Significant original updates to existing content labels Oct 2, 2019
@dobooth dobooth added the Waiting for Response Waiting for response from internal/external parties label Oct 17, 2019
@eduard13
Copy link
Contributor Author

eduard13 commented Oct 18, 2019 •
edited
Loading

Hi @dobooth, could you please let me know what response are we waiting here? 🤔
Thank you.

@eduard13
Copy link
Contributor Author

Hey @dobooth, any updates on this one?

@dobooth dobooth removed the Waiting for Response Waiting for response from internal/external parties label Oct 21, 2019
@dobooth
Copy link
Contributor

dobooth commented Oct 21, 2019

I think I was waiting for you to reply to Rogyar's concerns but he approved it. Sorry for delay.

@dobooth
Copy link
Contributor

dobooth commented Oct 21, 2019

running tests

@dobooth
Copy link
Contributor

dobooth commented Oct 21, 2019

running tests

@dobooth dobooth merged commit 8655b1d into magento:master Oct 21, 2019
@ghost
Copy link

ghost commented Oct 21, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 requested a review from dobooth October 31, 2019 18:05
@meker12 meker12 removed the Technical Updates to the code or processes that alter the technical content of the doc label Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogyar rogyar rogyar approved these changes

@dobooth dobooth Awaiting requested review from dobooth

Assignees

@rogyar rogyar

Labels
2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eduard13 @devops-devdocs @rogyar @dobooth @meker12 @magento-engcom-team