Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Update identity-class.md #5567

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Update identity-class.md #5567

merged 3 commits into from
Oct 14, 2019

Conversation

Vinai
Copy link
Contributor

@Vinai Vinai commented Oct 4, 2019

Purpose of this pull request

  • Import the correct Magento\Framework\GraphQl\Query\Resolver\IdentityInterface.
  • Clarify what is required and what is an implementation detail.

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.3/graphql/develop/identity-class.html

* Import the correct `Magento\Framework\GraphQl\Query\Resolver\IdentityInterface`.
* Clarify what is required and what is an implementation detail.
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar
Copy link
Contributor

rogyar commented Oct 4, 2019

@rogyar rogyar added 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels Oct 4, 2019
@dobooth
Copy link
Contributor

dobooth commented Oct 8, 2019

Hi @Vinai Looks like it wants you to sign the new Adobe CLA. Please do so and we can get this through.

@Vinai
Copy link
Contributor Author

Vinai commented Oct 9, 2019

@dobooth done! I thought signing it once for the magento/magento2 repository would suffice, but it seems to be required for each individual repository.

@dobooth
Copy link
Contributor

dobooth commented Oct 14, 2019

running tests

@dobooth
Copy link
Contributor

dobooth commented Oct 14, 2019

running tests

@dobooth dobooth merged commit 833bffe into magento:master Oct 14, 2019
@ghost
Copy link

ghost commented Oct 14, 2019

Hi @Vinai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants