This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Added third type of JS mixin #5630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Zilker Technology
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
1 similar comment
|
An admin must run tests on this PR before it can be merged. |
rogyar
suggested changes
Oct 9, 2019
rogyar
added
Technical
drpayyne
force-pushed
the
patch-11
branch
2 times, most recently
from
ba710a6 to
ad9d34b
Compare
rogyar
approved these changes
Oct 9, 2019
keharper
suggested changes
Oct 15, 2019
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
Co-Authored-By: Kevin Harper <[email protected]>
Co-Authored-By: Kevin Harper <[email protected]>
keharper
approved these changes
Oct 15, 2019
|
running tests |
|
@drpayyne This PR is failing the linting tests. Please remove the blank space at the end of line 120 and all the spaces on line 125. |
|
Fixed it, @keharper. Thank you |
keharper
approved these changes
Oct 21, 2019
|
running tests |
|
Hi @drpayyne, thank you for your contribution! |
|
Thanks @drpayyne |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds the third type of Javascript mixins for modules which return objects, instead of Ui Components or jQuery widgets. Example module: Magento_Checkout/.../step-navigator.js
Affected DevDocs pages