Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#: Docs: Create topic for addDownloadableProductsToCart mutation #5672

Merged
merged 2 commits into from
Oct 15, 2019
Merged

magento/devdocs#: Docs: Create topic for addDownloadableProductsToCart mutation #5672

merged 2 commits into from
Oct 15, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Oct 13, 2019 •
edited by keharper
Loading

Purpose of this pull request

This pull request (PR) fixes magento/graphql-ce#1003 issue.

Affected DevDocs pages

Links to Magento source code

CC: @keharper

Thank you!

whatsnew
Added the addDownloadableProductsToCart mutation.

@atwixfirster atwixfirster mentioned this pull request Oct 13, 2019
Closed
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Oct 13, 2019
rogyar
rogyar suggested changes Oct 14, 2019
View reviewed changes
guides/v2.3/graphql/mutations/add-downloadable-products.md Outdated

### DownloadableProductCartItemInput object {#DownloadableProductCartItemInput}

The `DownloadableProductCartItemInput` object must contain the following attributes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We say that the object must contain the following attributes, however, downloadable_product_links and customizable_options are optional attributes. So "must" is not the 100% correct assumption here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really a good point.

fixed

@rogyar rogyar added 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document labels Oct 14, 2019
@atwixfirster atwixfirster force-pushed the add-downloadable-products branch 2 times, most recently from 8f5c81e to d479ee8 Compare October 14, 2019 08:05
@atwixfirster
Copy link
Contributor Author

@rogyar , all your suggestions have been implemented. Could you please review?

Many thanks as always

lenaorobei
lenaorobei reviewed Oct 14, 2019
View reviewed changes
lenaorobei
lenaorobei reviewed Oct 14, 2019
View reviewed changes
@atwixfirster atwixfirster force-pushed the add-downloadable-products branch from d479ee8 to 7d241c0 Compare October 14, 2019 13:27
@atwixfirster
Copy link
Contributor Author

@lenaorobei , could you please review?

Thanks

keharper
keharper suggested changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few grammatical changes and minor edits

@atwixfirster atwixfirster force-pushed the add-downloadable-products branch from 7d241c0 to 45df331 Compare October 14, 2019 19:35
@atwixfirster
Copy link
Contributor Author

@keharper , all your suggestions have been implemented. Could you please review?

Thanks!

keharper
keharper reviewed Oct 15, 2019
View reviewed changes
guides/v2.3/graphql/mutations/add-downloadable-products.md Outdated

Attribute | Data Type | Description
--- | --- | ---
`data` | [CartItemInput!](#CartItemInputVirtual) | An object containing the `sku` and `quantity` of the product
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`data` | [CartItemInput!](#CartItemInputVirtual) | An object containing the `sku` and `quantity` of the product
`data` | [CartItemInput!](#CartItemInputVirtual) | Required. An object containing the `sku` and `quantity` of the product

@atwixfirster atwixfirster force-pushed the add-downloadable-products branch from 45df331 to 6daadd7 Compare October 15, 2019 05:45
@atwixfirster
Copy link
Contributor Author

@keharper ,

done :)

Could you please review again? Thanks

@keharper
Copy link
Contributor

running tests

@keharper
Copy link
Contributor

@atwixfirster The linting checks are failing. Please remove the extra spaces at the end of line 48. Also, remove the comma after line 39.

@atwixfirster atwixfirster force-pushed the add-downloadable-products branch from 71fdf8c to 0ea0e0d Compare October 15, 2019 15:09
@atwixfirster atwixfirster force-pushed the add-downloadable-products branch from 0ea0e0d to 0403535 Compare October 15, 2019 15:14
@atwixfirster
Copy link
Contributor Author

@atwixfirster The linting checks are failing. Please remove the extra spaces at the end of line 48. Also, remove the comma after line 39.

done

@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit d576279 into magento:develop Oct 15, 2019
@ghost
Copy link

ghost commented Oct 15, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Another new topic from @atwixfirster. Thanks!

@atwixfirster
Copy link
Contributor Author

Another new topic from @atwixfirster. Thanks!

With my pleasure, @keharper !

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rogyar rogyar rogyar approved these changes

@keharper keharper keharper approved these changes

@lenaorobei lenaorobei lenaorobei approved these changes

Assignees

@rogyar rogyar

@keharper keharper

@atwixfirster atwixfirster

@lenaorobei lenaorobei

Labels
2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@atwixfirster @devops-devdocs @keharper @rogyar @lenaorobei @magento-engcom-team