Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Update files.md #5896

Merged
merged 2 commits into from
Oct 31, 2019
Merged

Update files.md #5896

merged 2 commits into from
Oct 31, 2019

Conversation

dewimagento
Copy link
Contributor

Purpose of this pull request

(Handy and mostly unrelated tip:
I find the following bookmarklet handy for very wide code-reviews:

javascript:document.body.classList.toggle('full-width');
  • putting that in your bookmarks menu or bookmark bar and clicking it while, reviewing git's diff page, makes the git diff take the whole width of the browser.]

This PR updates the files.md file:

  • Fix "smart" unicode quotes throughout to correctly be the " and ' characters.
  • Wrap lines to ~120 chars throughout.
  • Add table of params for the Get files endpoint.
  • Clarify the explanation of the multipart form upload.
  • Remove all references to the DELETE file endpoint, no longer available to users (which I only finally got confirmation about just now, yay).

Affected DevDocs pages

https://devdocs.magento.com/guides/v2.3/marketplace/eqp/files.html

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@keharper keharper added Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc labels Oct 31, 2019
@shrielenee shrielenee assigned shrielenee and unassigned shrielenee Oct 31, 2019
@dobooth dobooth merged commit 56b847a into magento:eqp-integration Oct 31, 2019
@ghost
Copy link

ghost commented Oct 31, 2019

Hi @dewimagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants