Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Added new section for 2.3 parity #5934

Merged
merged 7 commits into from
Nov 8, 2019
Merged

Added new section for 2.3 parity #5934

merged 7 commits into from
Nov 8, 2019

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Nov 5, 2019

Custom layout updates flow has been changed for 2.3.4 and 2.2.11, here's a guide reflecting those changes

Purpose of this pull request

This pull request (PR) will guide front-end devs and merchants on the new flow of providing custom layout updates for cms pages, categories and products

Affected DevDocs pages

whatsnew
Added the 'Create cms-page/product/category-specific layouts' section to Common layout customization tasks.

@dobooth dobooth self-assigned this Nov 5, 2019
@dobooth dobooth added 2.2.x Major Update Significant original updates to existing content labels Nov 5, 2019
@dobooth dobooth requested a review from shrielenee November 6, 2019 14:42
Copy link
Contributor

@shrielenee shrielenee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - Have some suggestions.

where:

- _Category ID_ is desired category ID
- _Layout Update Name_ is what is shown as the option for __Custom layout update__ field of __Design__ section on _Category Edit_ page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a little inconsistent regarding complete sentences vs. not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I debate that every time.


where:

- _CMS Page Identifier_ is the desired page's _URL Key_ with "/" symbols replaced with "_"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- _CMS Page Identifier_ is the desired page's _URL Key_ with "/" symbols replaced with "_"
- _CMS Page Identifier_ is the desired page's _URL Key_ with "/" symbols replaced with "_".


- _CMS Page Identifier_ is the desired page's _URL Key_ with "/" symbols replaced with "_"
- _Layout Update Name_ is what is shown as the option for __Custom layout update__ field of __Design__
section on _CMS Page Edit_ page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on a separate line than the sentence it is within?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unwrapped

@dobooth
Copy link
Contributor Author

dobooth commented Nov 8, 2019

running tests

@dobooth dobooth merged commit 3a35eb2 into develop Nov 8, 2019
@ghost
Copy link

ghost commented Nov 8, 2019

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the dobooth-patch-1 branch November 8, 2019 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants