Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Markdown linting: Enable rule MD032 (lists should be surrounded by blank lines) #5957

Merged
merged 3 commits into from
Nov 8, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _checks/styles/style-rules-prod
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ exclude_rule 'MD028'
rule 'MD029'
rule 'MD030', :ul_single => 2, :ol_single => 1, :ul_multi => 2, :ol_multi => 1
exclude_rule 'MD031'
exclude_rule 'MD032'
rule 'MD032'
exclude_rule 'MD033'
exclude_rule 'MD034'
rule 'MD035'
Expand Down
1 change: 1 addition & 0 deletions _includes/config/setup-cron_2.2_about.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ Magento uses cron for two sets of tasks, and for each, cron can run with a diffe
* Web server PHP plug-in configuration: Two other cron jobs are used by the [Component Manager and System Upgrade utilities]({{ page.baseurl }}/comp-mgr/bk-compman-upgrade-guide.html).

{: .bs-callout-warning }

* To avoid issues during installation and upgrade, we strongly recommend you apply the same PHP settings to both the PHP command-line configuration and to the PHP web server plug-in's configuration. For more information, see [Required PHP settings]({{ page.baseurl }}/install-gde/prereq/php-settings.html).
* In a multi-node system, crontab can run on only one node. This applies to you only if you set up more than one webnode for reasons related to performance or scalability.
1 change: 1 addition & 0 deletions _includes/config/setup-cron_2.2_how-to.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ To create the Magento crontab:
Use `--force` to rewrite an existing Magento crontab.

{: .bs-callout-info }

* `magento cron:install` does not rewrite an existing crontab inside `#~ MAGENTO START` and `#~ MAGENTO END` comments in your crontab.
* `magento cron:install --force` has no effect on any cron jobs outside the Magento comments.

Expand Down
1 change: 1 addition & 0 deletions _includes/config/setup-cron_2.3_how-to.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ To create the Magento crontab:
Use `--force` to rewrite an existing Magento crontab.

{: .bs-callout-info }

* `magento cron:install` does not rewrite an existing crontab inside `#~ MAGENTO START` and `#~ MAGENTO END` comments in your crontab.
* `magento cron:install --force` has no effect on any cron jobs outside the Magento comments.

Expand Down
4 changes: 4 additions & 0 deletions guides/v2.2/cloud/cdn/trouble-fastly.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,17 @@ Verify that the returned response contains the following information:
The following excerpt from the cURL command output shows the correct values for the `Pragma`, `X-Magento-Tags`, and `Fastly-Module-Enabled` headers:

```terminal

* STATE: INIT => CONNECT handle 0x600057800; line 1402 (connection #-5000)
* Rebuilt URL to: https://www.mymagento.biz.c.sv7gVom4qrpek.ent.magento.cloud/
* Added connection 0. The cache now contains 1 members
* Trying 192.0.2.31...
* STATE: CONNECT => WAITCONNECT handle 0x600057800; line 1455 (connection #0)

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0* Connected to www.mymagento.biz.c.sv7gVom4qrpek.ent.magento.cloud (54.229.163.31) port 443 (#0)

* STATE: WAITCONNECT => SENDPROTOCONNECT handle 0x600057800; line 1562 (connection #0)
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0* ALPN, offering h2

Expand All @@ -242,6 +245,7 @@ The following excerpt from the cURL command output shows the correct values for
* multi_done
0 0 0 0 0 0 0 0 --:--:-- 0:00:02 --:--:-- 0
* Connection #0 to host www.mymagento.biz.c.sv7gVom4qrpek.ent.magento.cloud left intact

```

{: .bs-callout-info }
Expand Down
2 changes: 2 additions & 0 deletions guides/v2.2/cloud/composer-packages/ece-patches.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,11 @@ Implemented version-based patching. Now the package is compatible with {{site.da
### Fixed issues

<!--MAGECLOUD-1033-->

- Removed patch; fixing bug in `colinmollenhour/credis` v1.6 to enable support for {{site.data.var.ece}} 2.2.1.

## v102.0.0

{:.bs-callout .bs-callout-warning}
This package is no longer compatible with other versions of {{site.data.var.ece}} and **should not** be used.

Expand Down
4 changes: 4 additions & 0 deletions guides/v2.2/cloud/release-notes/CloudReleaseNotes2.2.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,13 @@ In general, we’ve removed serialize/unserialize from most the code to improve
### New Updates

<!--- MAGECLOUD-1057 -->

* Magento Commerce (Cloud) supports scopes and [static content deployment strategies]({{ site.baseurl }}/guides/v2.2/config-guide/cli/config-cli-subcommands-static-deploy-strategies.html). We have added the `–s` parameter with a default setting of quick for the static content deployment strategy. You can use the environment variable [SCD_STRATEGY]({{ site.baseurl }}/guides/v2.2/cloud/env/environment-vars_magento.html) to customize and use these strategies with your build and deploy actions. This variable supports the options standard quick, or compact. If you select compact, we override the `STATIC_CONTENT_THREADS` value with 1, which can slow deployment, especially in production environments.

* When you create a new project, we automatically provision the project with the latest Magento Commerce (Cloud) code. The steps include cloning the latest code repository, adding an environment variable for `ADMIN_EMAIL` using the License Owner’s email, setting a default randomized Magento Admin password, and sending emails to the License Owner to access the project and reset the default Magento Admin password. For details, see [Onboarding tasks]({{ site.baseurl }}/guides/v2.2/cloud/onboarding/onboarding-tasks.html).

<!--- MAGECLOUD-1014, 1023 -->

* We have created a new log file on environments to capture and compile build and deploy actions. The file is located in the `app/var/log/cloud.log` file inside the Magento root application directory.

## Known issues {#known}
Expand All @@ -47,9 +49,11 @@ For all known {{site.data.var.ee}} 2.2.1 issues, see [Magento Commerce 2.2.1 Re
## Fixed issues {#fixed}

<!-- MAGECLOUD-1355 -->

* You can now [manually reset stuck Magento cron jobs]({{ site.baseurl }}/guides/v2.2/cloud/trouble/reset-cron-jobs.html) using a CLI command in all environments via SSH access. The deployment process automatically resets cron jobs. You must [patch magento/ece-tools]({{ site.baseurl }}/guides/v2.2/cloud/project/project-patch.html) to get this update.

<!--- MAGECLOUD-1121 -->

* We resolved an issue with the ElasticSearch option being added and saved to `app/etc/env.php`. When ElasticSearch is configured and activated in your environment, the setting properly saves in the `env.php` file. For example:

<code><?php
Expand Down
8 changes: 8 additions & 0 deletions guides/v2.2/cloud/release-notes/CloudReleaseNotes2.2.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,23 @@ For all known {{site.data.var.ee}} 2.2.0 GA issues, see [Magento Commerce 2.2.0
This release contains numerous fixes and enhancements. This section includes only fixes for {{site.data.var.ece}}. For all known {{site.data.var.ee}} 2.2.0 GA issues, see [Magento Commerce 2.2.0 Release Notes]({{ site.baseurl }}/guides/v2.2/release-notes/ReleaseNotes2.2.0EE.html).

<!--RFC-125-->

* We removed `var/view_preprocessed` symlinking to fix an issue that was causing JavaScript minification conflicts.

<!-- MAGECLOUD-1355 -->

* You can now [manually reset stuck Magento cron jobs]({{ site.baseurl }}/guides/v2.2/cloud/trouble/reset-cron-jobs.html) using a CLI command in all environments via SSH access. The deployment process automatically resets cron jobs. You must [patch magento/ece-tools]({{ site.baseurl }}/guides/v2.2/cloud/project/project-patch.html) to get this update.

<!-- 57167 -->

* You can now generate sitemap.xml and robots.txt normally through the Magento Admin panel, without needing to move the file and have a redirect entered. If you are upgrading to 2.2, please enter a [Support ticket] to have any redirects removed for sitemap and robots.txt.

<!-- MAGECLOUD-894 -->

* Newly provisioned {{site.data.var.ece}} receive an email to change the Magento Admin password. For enhanced security, we generate a random password for the username "admin" and send an email to the Project Owner to properly set up Admin access for Starter `master` Production environment and the Pro Integration `master` environment.

<!-- MAGECLOUD-1025 MAGECLOUD-930 -->

* We added additional environment variables and updated build and deploy hooks to [`.magento.app.yaml`]({{ site.baseurl }}/guides/v2.2/cloud/project/project-conf-files_magento-app.html).

* When upgrading to {{site.data.var.ece}} 2.2.0, you will need to update your `.magento.app.yaml` file and Configuration Management `config.local.php` file. See [Upgrade Magento Commerce (Cloud)]({{ site.baseurl }}/guides/v2.2/cloud/project/project-upgrade.html).
Expand All @@ -79,12 +84,15 @@ This release contains numerous fixes and enhancements. This section includes onl
* We’ve added support for the latest version of Redis and for PHP-Redis 3.1.3. For more information on this update, and for guidance on Redis troubleshooting on {{site.data.var.ece}}, see [Redis troubleshooting]({{ site.baseurl }}/guides/v2.2/cloud/trouble/redis-troubleshooting.html).

<!--- 55462/52448-->

* Magento now correctly displays customer address during account creation. Previously, when you selected a default billing address during creation of a new customer account, Magento would not display the address.

<!---61104 -->

* When you delete an image in Admin, Magento no longer deletes it on the server. Previously, Magento deleted it from the server as well, which caused errors for other products (example error message: `Cannot gather stats! Warning!stat(): stat failed for`).

<!--- 68833 -->

* We’ve fixed errors in processing valid orders using a PayPal account that had been previously used to pay for a valid order that had problems during checkout.

## Changes in Deployment {#deploy}
Expand Down
1 change: 1 addition & 0 deletions guides/v2.2/mrg/ce/Signifyd.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ The following interfaces (marked with the `@api` annotation) extend the Signifyd
- send a request through the Signifyd API to create a new case guarantee

`Magento\Signifyd\Api\GuaranteeCancelingServiceInterface`:

- send a request through the Signifyd API to cancel the Signifyd case guarantee

`Magento\Signifyd\Api\Data\CaseSearchResultsInterface`:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ The Magento application should be accessible for all people, whatever their hard

- **Be mindful of text length**—Don't make textual content too long or too short.

- **Provide adequate contrast**—Be extra careful with light shades of gray, orange, and yellow. Check your contrast levels here:
[http://webaim.org/resources/contrastchecker/](http://webaim.org/resources/contrastchecker/){:target="_blank"}
or here: [http://www.paciellogroup.com/resources/contrastAnalyser](http://www.paciellogroup.com/resources/contrastAnalyser){:target="_blank"}
- **Provide adequate contrast**—Be extra careful with light shades of gray, orange, and yellow. Check your contrast levels here: [http://webaim.org/resources/contrastchecker/](http://webaim.org/resources/contrastchecker/){:target="_blank"} or here: [http://www.paciellogroup.com/resources/contrastAnalyser](http://www.paciellogroup.com/resources/contrastAnalyser){:target="_blank"}

**Acceptable**

Expand Down
Loading