This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Small changes #6455
Merged
Small changes #6455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve code error.
Added wrappers for notices about db_schema_whitelist.json file
Added a point mentioning to make texts translatable with an example
We do not need to add the Blank theme's CSS files again in our theme, since we are extending the file default_head_blocks.xml.
remove double quote to make code perfect usable
Added wrappers for notices
Co-Authored-By: hguthrie <[email protected]>
Update on include an external CSS code
Added a point for Theme development best practices
Change from: "mysql -h<db> -p<number> -u<username> -p<password>" to: "mysql -h<db> -P<number> -u<username> -p<password>" That is, change the first lowercase "-p" to an uppercase "-P". The lowercase "-p" is for the password (as seen in the second instance of "-p"). The first instance is supposed to be the option to set the port, which should be an uppercase "-P".
* Text edits in config-mq * Amend confusing anchor text * Typo * Code sample typo
This PR is intended to fix a wrong code reference that points to a non-existing `view_model` argument mentioned in the docs.
Update code reference to view_model
adding information the find information about sendgrid
config-varnish-magento.md. Minor change as per standard.
config-varnish-advanced.md Minor Change.
inventory-api-reference.md Corrected broken tables.
config-varnish-advanced.md Minor Change
Fix tables in inventory-api-reference.md
Providing a list of allowed tags that can be used as HtmlTag on containers
* magento/devdocs#: Add generateCustomerToken mutation API errors https://devdocs.magento.com/guides/v2.3/graphql/mutations/generate-customer-token.html * Update generate-customer-token.md Co-authored-by: Kevin Harper <[email protected]>
Add global "Commerce-only" designation to Page Builder content
Fixed broken link
jeff-matthews
previously approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Content looks good, but a local test indicates a couple of trailing space linting errors:
rake test:md
Testing Markdown style with mdl ...
src/guides/v2.3/graphql/mutations/create-braintree-client-token.md:37: MD009 Trailing spaces
src/guides/v2.3/graphql/mutations/delete-payment-token.md:81: MD009 Trailing spaces
A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md
The Markdown linter detected 2 issue(s)
|
running tests |
jeff-matthews
approved these changes
Jan 24, 2020
|
Hi @dobooth, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request