Declaring the logo size #7023
Declaring the logo size #7023
Conversation
magento-engcom-team
added
Partner: Krish TechnoLabs
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
| @@ -83,6 +83,8 @@ To customize the Admin theme logo: | |||
| <referenceBlock name="logo"> | |||
| <arguments> | |||
| <argument name="logo_image_src" xsi:type="string">images/custom-logo.svg</argument> | |||
| <argument name="logo_img_width" xsi:type="number">150</argument> <!-- Add custom logo width --> | |||
There was a problem hiding this comment.
Hi @abrarpathan19. Thank you for your contribution. Could you, please, refer to the functional part of the codebase that operates with logo_img_width and logo_img_height parameters? I'm unable to find this logic in the Magento\Backend\Block\Page\Header class or related functional parts.
Thank you!
There was a problem hiding this comment.
Hello @rogyar,
Thanks for review. This is the customize the Admin theme logo section so, I have added custom with and height for the logo.
There was a problem hiding this comment.
Be aware that logo_img_width and logo_img_height are being replaced with logo_width and logo_height as of Magento 2.3.5. See magento/magento2#25042 (comment) for more info.
There was a problem hiding this comment.
Good eye, @hostep. @abrarpathan19, if you want to get this change into 2.3.5-develop, that would be great.
There was a problem hiding this comment.
Hi @dobooth. Since the mentioned parameters were removed from the codebase and replaced by new parameters (logo_width and logo_height), we may leave it in the master branch but adjust the parameter names to reflect the actual state in the codebase. @abrarpathan19 would you make this change, please?
|
Hello @rogyar, |
rogyar
added
Technical
|
running tests |
|
Hi @abrarpathan19, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) will provide information for Declaring the logo size
Affected DevDocs pages
Links to Magento source code