-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Adding errors section for addBundleProductsToCart mutation #7151
Adding errors section for addBundleProductsToCart mutation #7151
Conversation
An admin must run tests on this PR before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @VinothKumar361, thank you for your contribution!
Could you please check and apply the following improvements if you agree.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VinothKumar361 Good catch on the attribute syntax. It seems that GraphiQL and GraphQL Playground don't always display types with two exclamation points correctly.
@dmytro-ch would you review/approve @VinothKumar361's changes? |
Sure, sorry for the late reply. |
running tests |
Hi @VinothKumar361, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) adds errors section for addBundleProductToCart Mutation and also adds non nullable object notations
Affected DevDocs pages
Links to Magento source code
https://github.com/magento/magento2/blob/5f3b86ab4bd3e3b94e65429fed33f748d29c1bbe/app/code/Magento/BundleGraphQl/etc/schema.graphqls#L16
https://github.com/magento/magento2/blob/5f3b86ab4bd3e3b94e65429fed33f748d29c1bbe/app/code/Magento/BundleGraphQl/etc/schema.graphqls#L10