Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Adding errors section for addBundleProductsToCart mutation #7151

Conversation

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @VinothKumar361, thank you for your contribution!
Could you please check and apply the following improvements if you agree.

Thank you!

@dmytro-ch dmytro-ch added the 2.3.x Magento 2.3 related changes label May 4, 2020
@keharper keharper added the Technical Updates to the code or processes that alter the technical content of the doc label May 5, 2020
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VinothKumar361 Good catch on the attribute syntax. It seems that GraphiQL and GraphQL Playground don't always display types with two exclamation points correctly.

@keharper
Copy link
Contributor

keharper commented May 5, 2020

@dmytro-ch would you review/approve @VinothKumar361's changes?

@dmytro-ch
Copy link
Contributor

Sure, sorry for the late reply.
@VinothKumar361, thank you for the updates!

@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 57270d5 into magento:master May 12, 2020
@ghost
Copy link

ghost commented May 12, 2020

Hi @VinothKumar361, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Partner: Ziffity partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants