Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Whatsnew update for week of May 11 #7218

Merged
merged 3 commits into from
May 14, 2020
Merged

Whatsnew update for week of May 11 #7218

merged 3 commits into from
May 14, 2020

Conversation

jfrontain
Copy link
Contributor

Purpose of this pull request

This pull request (PR) updates the whatsnew info feed for the week of may 11 - 14.

Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix update date and remove Rakefile

@@ -1,11 +1,48 @@
title: Whats New on Devdocs
description: |
description:
This page contains recent changes that we think you'd like to know about.
We exclude from this list proofreading, spelling checks, and all minor updates.
link: /whats-new.html
thread: /whatsnew-feed.xml
updated: Tue May 5 12:22:39 2020
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated date should reflect the date that you generated the updated content. You can get it from the tmp file.

@meker12 meker12 self-requested a review May 14, 2020 20:08
@jfrontain
Copy link
Contributor Author

running tests

@jfrontain
Copy link
Contributor Author

running tests

@jfrontain jfrontain merged commit 8bbd0ae into master May 14, 2020
@ghost
Copy link

ghost commented May 14, 2020

Hi @jfrontain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 deleted the whatsnew-this-week branch May 14, 2020 21:25
Copy link
Collaborator

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't available on May 14, but I'd like to add my review comments.

@@ -1,11 +1,48 @@
title: Whats New on Devdocs
description: |
description:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a reason why this pipeline was there. Whatsnew updates can update only updated and etnries.

@@ -91,4 +91,4 @@ task :convert do
result = `bin/kramdown --input=html --output=kramdown`
puts 'Converted text:'.magenta
puts result.bold
end
end
Copy link
Collaborator

@dshevtsov dshevtsov May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A whatsnew update PR must not change any other files but src/_data/whats-new.yml, especially when this is an infrastructure file. I don't believe that an author and a reviewer didn't notice this change.

type: Technical
date: May 12, 2020
link: https://github.com/magento/devdocs/pull/7199
- description: Added Release Notes and updated Merchant Documentation for the Amazon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should contain links to the updated topics.

link: https://github.com/magento/devdocs/pull/7199
- description: Added Release Notes and updated Merchant Documentation for the Amazon
Sales Channel 4.1.0 release.
versions: ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version should be specified.

- description: Added [Bypass Fastly](https://devdocs.magento.com/cloud/cdn/fastly-vcl-bypass-to-origin.html)
topic with instructions for creating a custom VCL snippet to bypass Fastly on
requests from a specific IP address, URL, or URL pattern.
versions: ''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version should be specified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants