-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix update date and remove Rakefile
src/_data/whats-new.yml
Outdated
@@ -1,11 +1,48 @@ | |||
title: Whats New on Devdocs | |||
description: | | |||
description: | |||
This page contains recent changes that we think you'd like to know about. | |||
We exclude from this list proofreading, spelling checks, and all minor updates. | |||
link: /whats-new.html | |||
thread: /whatsnew-feed.xml | |||
updated: Tue May 5 12:22:39 2020 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated date should reflect the date that you generated the updated content. You can get it from the tmp
file.
running tests |
running tests |
Hi @jfrontain, thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't available on May 14, but I'd like to add my review comments.
@@ -1,11 +1,48 @@ | |||
title: Whats New on Devdocs | |||
description: | | |||
description: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a reason why this pipeline was there. Whatsnew updates can update only updated
and etnries
.
@@ -91,4 +91,4 @@ task :convert do | |||
result = `bin/kramdown --input=html --output=kramdown` | |||
puts 'Converted text:'.magenta | |||
puts result.bold | |||
end | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A whatsnew update PR must not change any other files but src/_data/whats-new.yml
, especially when this is an infrastructure file. I don't believe that an author and a reviewer didn't notice this change.
type: Technical | ||
date: May 12, 2020 | ||
link: https://github.com/magento/devdocs/pull/7199 | ||
- description: Added Release Notes and updated Merchant Documentation for the Amazon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should contain links to the updated topics.
link: https://github.com/magento/devdocs/pull/7199 | ||
- description: Added Release Notes and updated Merchant Documentation for the Amazon | ||
Sales Channel 4.1.0 release. | ||
versions: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version should be specified.
- description: Added [Bypass Fastly](https://devdocs.magento.com/cloud/cdn/fastly-vcl-bypass-to-origin.html) | ||
topic with instructions for creating a custom VCL snippet to bypass Fastly on | ||
requests from a specific IP address, URL, or URL pattern. | ||
versions: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version should be specified.
Purpose of this pull request
This pull request (PR) updates the whatsnew info feed for the week of may 11 - 14.