This repository was archived by the owner on Nov 19, 2024. It is now read-only.
GraphQL: Add support for downloadable/gift card products in customer …#7716
Merged
keharper merged 9 commits into2.4.1-developfrom Aug 17, 2020
Merged
GraphQL: Add support for downloadable/gift card products in customer …#7716keharper merged 9 commits into2.4.1-developfrom
keharper merged 9 commits into2.4.1-developfrom
Conversation
keharper
added
Internal Dev
danielrenaud
approved these changes
Aug 12, 2020
cpartica
approved these changes
Aug 17, 2020
erikmarr
approved these changes
Aug 17, 2020
Contributor
erikmarr
left a comment
erikmarr
left a comment
There was a problem hiding this comment.
Looks good...just one minor question.
| --- | --- | --- | ||
| `additional_data` | [[KeyValue](#KeyValue)] | Additional data per payment method type | ||
| `name` | String! | The label that describes the payment method | ||
| `type` | String! | The payment method code that indicates how the order was paid for |
Contributor
There was a problem hiding this comment.
can we/should we list the possible payment method codes that this attribute can return?
Contributor
Author
There was a problem hiding this comment.
No. The payment reference section is meant to be definitive source of that. Moreover, 3rd party payment processors should be supporting GraphQL now or soon, and we can't know their values.
Contributor
Author
|
running tests |
|
Hi @keharper, thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…orders
Purpose of this pull request
This pull request (PR) adds attributes that support downloadable products and gift cards in a customer order.
I also added schema changes made in internal ticket MC-35987
Affected DevDocs pages
Links to Magento source code