This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Update php extensions template to include ext-sockets #7953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meker12
added
2.x
Internal Dev
dshevtsov
approved these changes
Sep 30, 2020
hostep
reviewed
Sep 30, 2020
| {% else %} | ||
|
|
||
| {:.bs-callout-warning} | ||
| If you install Magento by cloning from the [GitHub](https://github.com/magento/magento2) repository, you must have the [ext-sockets](https://github.com/php-amqplib/php-amqplib/blob/master/CHANGELOG.md#281---2018-11-13) installed on your instance. |
There was a problem hiding this comment.
Like mentioned previously, I would remove this, it only applies for Magento 2.3.4 and 2.3.5. And who is installing Magento by cloning the git repo anyways? It's not really recommended for production deployments and now that those versions are outdated I don't see the point of mentioning this notice.
Just my 2 cents.
hostep
approved these changes
Sep 30, 2020
|
running tests |
|
Hi @meker12, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Update the PHP extensions template to include
ext-socketsrequirements in v2.3 and 2.4.Affected DevDocs pages