This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest: Avoid using terms like execute and terminate:
Do not run the
composer dump-autoloadcommand.Why do you need to set this variable? Do you only set it if you are deploying Cloud project using Magento Cloud Docker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meker12 Executing
composer dump-autoloadcommand causes an error when running some Magento commands such asbin/magento deploy:mode:set productionorbin/magento -n setup:upgrade. These commands can be run on writable systems, for example in the magento-cloud-dockertestcontainer. So we added a possibility to skip it.This is a core issue magento/magento2#23251, but I don't know when it will be fixed.