Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Moved the else logic before if condition #8080

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Moved the else logic before if condition #8080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/guides/v2.4/extension-dev-guide/searching-with-repositories.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,11 @@ class ProductCategoryFilter implements CustomFilterInterface
{
$value = $filter->getValue();
$conditionType = $filter->getConditionType() ?: 'in';
$filterValue = [$value];
if (($conditionType === 'in' || $conditionType === 'nin') && is_string($value)) {
$value = explode(',', $value);
} else {
$value = [$value];
$filterValue = explode(',', $value);
}
$categoryFilter = [$conditionType => $value];
$categoryFilter = [$conditionType => $filterValue];

/** @var Collection $collection */
$collection->addCategoriesFilter($categoryFilter);
Expand Down