Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add Braintree VBE and update UG links #8151

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Conversation

leslietilling
Copy link
Contributor

Purpose of this pull request

This pull request (PR) updates the VBE page to include Braintree as a VBE and update the URLs for user guide links using the old URL path.

Affected DevDocs pages

@leslietilling leslietilling added the Internal Dev Differentiates work between community and Magento staff label Oct 29, 2020
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add Braintree to the compatibility matrix?

@leslietilling
Copy link
Contributor Author

Do we need to add Braintree to the compatibility matrix?

Yes, we should. In 2.4.0, it was removed as core integration and added as VBE.

@dobooth
Copy link
Contributor

dobooth commented Nov 9, 2020

@leslietilling

@leslietilling
Copy link
Contributor Author

leslietilling commented Dec 9, 2020

@jeff-matthews This is the version information from Daisy:

Braintree Version| Magento Version
v4.1.0 | v2.4.0
v4.2.0| v2.4.1

@jeff-matthews
Copy link
Contributor

I'll add the 2.4.0 entry in this PR and open a new PR to the 2.4.2-develop branch to add the 2.4.1 entry.

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit a0aa3bf into master Dec 9, 2020
@ghost
Copy link

ghost commented Dec 9, 2020

Hi @leslietilling, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@jeff-matthews jeff-matthews deleted the leslietilling-patch-2 branch December 9, 2020 20:27
@jeff-matthews
Copy link
Contributor

Oops... I just realized that we didn't update the matrix for 2.4.1 and I confused myself thinking that 2.4.1 was the next release.

I've added 2.4.1 entries for all other VBEs in the 2.4.2-develop branch, so I'm going to stick to the plan and add the Braintree entry for 2.4.1 there as well. We've gone this long, what's a few more days?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest-accepted Internal Dev Differentiates work between community and Magento staff Maintenance Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants