-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added an explanation on how to pass data to the script via data-mage-init and to access them in the script. #8311
Added an explanation on how to pass data to the script via data-mage-init and to access them in the script. #8311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition - just need some formatting issues sorted
Co-authored-by: Barny Shergold <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking a lot cleaner - a few format errors left
Also you have some linting errors - please correct - they are trailing space issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last small suggestion! All good after that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sathiyaaa. Please address my editorial suggestions and I'll merge this.
editorial changes from the code review Co-authored-by: Jeff Matthews <[email protected]>
running tests |
Hi @sathiyaaa, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) covers #8256
Affected DevDocs pages
whatsnew
Added an explanation and example of passing parameters to JavaScript using the
data-mage-init
HTML attribute.