This repository was archived by the owner on Nov 19, 2024. It is now read-only.
correct path for di.xml #8443
Merged
correct path for di.xml #8443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleron75
approved these changes
Dec 27, 2020
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
keharper
added
2.3.x
keharper
approved these changes
Jan 3, 2021
|
Hi @fooman, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request fixes error
Unable to load theme by specified key: ''
with created admin theme on product edit page when following the devdocs guide.
Affected DevDocs pages
https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/themes/admin_theme_apply.html#specify_di
Also see discussion here
https://magento.stackexchange.com/questions/302592/unable-to-load-theme-by-specified-key-magento-2-3-4
This seems to be the last related ticket
magento/magento2#26433
that once implemented may make etc/adminhtml/di.xml work (again?). However as of now the proposed changes here avoid creating an unusable admin theme.