This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Added the error coverage for category query #8489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: EY
partners-contribution
BarnyShergold
suggested changes
Jan 8, 2021
|
|
||
| Error | Description | ||
| --- | --- | ||
| `Category doesn't exist` | The specified category-id value does not exist. |
There was a problem hiding this comment.
Suggested change
| `Category doesn't exist` | The specified category-id value does not exist. | |
| `Category doesn't exist` | The specified category ID value does not exist. |
| Error | Description | ||
| --- | --- | ||
| `Category doesn't exist` | The specified category-id value does not exist. | ||
| `Field \"category\" argument \"id\" requires type Int, found "XXX" ` | The given category-id is not of type `int`, which is the required type. |
There was a problem hiding this comment.
The suggestion is what other docs have said in this case - so consistency + should solve linting
Suggested change
| `Field \"category\" argument \"id\" requires type Int, found "XXX" ` | The given category-id is not of type `int`, which is the required type. | |
| `Field "category" argument "id" requires type Int, found "XXX" ` | The specified `id` argument value has the wrong type. |
|
|
||
| Error | Description | ||
| --- | --- | ||
| `Category doesn't exist` | The specified category-id value does not exist. |
There was a problem hiding this comment.
Suggested change
| `Category doesn't exist` | The specified category-id value does not exist. | |
| `Category doesn't exist` | The specified category ID value does not exist. |
| Error | Description | ||
| --- | --- | ||
| `Category doesn't exist` | The specified category-id value does not exist. | ||
| `Field \"category\" argument \"id\" requires type Int, found "XXX" ` | The given category-id is not of type `int`, which is the required type. |
There was a problem hiding this comment.
Suggested change
| `Field \"category\" argument \"id\" requires type Int, found "XXX" ` | The given category-id is not of type `int`, which is the required type. | |
| `Field "category" argument "id" requires type Int, found "XXX" ` | The specified `id` argument value has the wrong type. |
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
keharper
added
2.3.x
keharper
approved these changes
Jan 8, 2021
|
running tests |
|
Hi @dineshvb, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds the error coverage for category query.
Affected DevDocs pages