-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update index.php location #8762
Conversation
|
@Viper9x - Can you signed the Adobe CLA please? |
BarnyShergold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Viper9x
Please can you add the correct information to the PR description - you need to include a link to the page(s) involved.
Secondly, you seem to have replaced the content of the symlink file by pasting in the content of the 2.3 version and changing it - this can't be done this way.
You need to revert the changes, then follow this process : https://github.com/magento/devdocs/wiki/Symlinks to replace the 2.4 file with a copy of the 2.3, THEN make the change and then commit.
THis is what is causing the lint check to fail. I suspect it thinks the complete file content is the filename the symlink points to 😄
|
@BarnyShergold Thanks for letting me know all about them, I've signed Adobe CLA. I'll edit the file now. |
@BarnyShergold I want to update page content on v2.4 because its content must be changed in Magento 2.4 release and nothing changes on v2.3. What should I do right now? |
|
@Viper9x Run the following command rake symlink:replace_at src/guides/v2.4/config-guide/bootstrap/magento-bootstrap.md Breaking a symlink makes the changed file look like a new file. It would help with the review if you state which lines/sections you changed. |
|
Also, the Adobe CLA signature didn't seem to stick. Try closing and reopening the PR. |
|
Hi @Viper9x, thank you for your contribution! |
|
I gave the wrong command earlier. It should be rake symlink:replace_at path=src/guides/v2.4/config-guide/bootstrap/magento-bootstrap.md |
|
@BarnyShergold I've done the changes, please review. |
BarnyShergold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great now!
I used a text compare to check for actual changes :)
|
@BarnyShergold I want to modify the content for some pages (minor change), what should I do? Commit to this branch or create a new branch for it? |
Is it is directly related to this issue then you can add it to this PR. If they are unrelated pages then it should be a different PR. Also if you have small corrections to several pages then you can have a "Minor Corrections" PR - so you don't end up with 10 PRs each with one page and one tiny correction! |
|
Yes, I have small corrections to several pages so I'll do it on another PR. Thanks @BarnyShergold |
|
@magento import code to magento-devdocs/devdocs |
|
@dobooth the branch with code successfully imported into |
|
Hi @Viper9x, thank you for your contribution! |
Purpose of this pull request
This pull request (PR) updated Magento application initialization and bootstrap page content
Affected DevDocs pages
Magento application initialization and bootstrap
https://devdocs.magento.com/guides/v2.4/config-guide/bootstrap/magento-bootstrap.html