Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

@TuVanDev
Copy link
Member

@TuVanDev TuVanDev commented Mar 2, 2021

Purpose of this pull request

This pull request (PR) updated Magento application initialization and bootstrap page content

Affected DevDocs pages

Magento application initialization and bootstrap
https://devdocs.magento.com/guides/v2.4/config-guide/bootstrap/magento-bootstrap.html

@magento-engcom-team
Copy link

@Viper9x thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@BarnyShergold
Copy link
Contributor

@Viper9x - Can you signed the Adobe CLA please?

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Viper9x
Please can you add the correct information to the PR description - you need to include a link to the page(s) involved.

Secondly, you seem to have replaced the content of the symlink file by pasting in the content of the 2.3 version and changing it - this can't be done this way.

You need to revert the changes, then follow this process : https://github.com/magento/devdocs/wiki/Symlinks to replace the 2.4 file with a copy of the 2.3, THEN make the change and then commit.

THis is what is causing the lint check to fail. I suspect it thinks the complete file content is the filename the symlink points to 😄

@TuVanDev
Copy link
Member Author

TuVanDev commented Mar 2, 2021

@BarnyShergold Thanks for letting me know all about them, I've signed Adobe CLA. I'll edit the file now.

@TuVanDev
Copy link
Member Author

TuVanDev commented Mar 2, 2021

You need to revert the changes, then follow this process : https://github.com/magento/devdocs/wiki/Symlinks to replace the 2.4 file with a copy of the 2.3, THEN make the change and then commit.

@BarnyShergold I want to update page content on v2.4 because its content must be changed in Magento 2.4 release and nothing changes on v2.3. What should I do right now?
"DevDocs uses symlinks to inherit content from a previous minor version for topics that have not been affected by new releases."

@keharper
Copy link
Contributor

keharper commented Mar 2, 2021

@Viper9x Run the following command

rake symlink:replace_at src/guides/v2.4/config-guide/bootstrap/magento-bootstrap.md

Breaking a symlink makes the changed file look like a new file. It would help with the review if you state which lines/sections you changed.

@keharper
Copy link
Contributor

keharper commented Mar 2, 2021

Also, the Adobe CLA signature didn't seem to stick. Try closing and reopening the PR.

@TuVanDev TuVanDev closed this Mar 2, 2021
@ghost
Copy link

ghost commented Mar 2, 2021

Hi @Viper9x, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

keharper commented Mar 2, 2021

I gave the wrong command earlier. It should be

rake symlink:replace_at path=src/guides/v2.4/config-guide/bootstrap/magento-bootstrap.md

@TuVanDev
Copy link
Member Author

TuVanDev commented Mar 4, 2021

@BarnyShergold I've done the changes, please review.

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great now!
I used a text compare to check for actual changes :)

@TuVanDev
Copy link
Member Author

TuVanDev commented Mar 5, 2021

@BarnyShergold I want to modify the content for some pages (minor change), what should I do? Commit to this branch or create a new branch for it?

@BarnyShergold
Copy link
Contributor

@BarnyShergold I want to modify the content for some pages (minor change), what should I do? Commit to this branch or create a new branch for it?

Is it is directly related to this issue then you can add it to this PR. If they are unrelated pages then it should be a different PR. Also if you have small corrections to several pages then you can have a "Minor Corrections" PR - so you don't end up with 10 PRs each with one page and one tiny correction!

@TuVanDev
Copy link
Member Author

TuVanDev commented Mar 5, 2021

Yes, I have small corrections to several pages so I'll do it on another PR. Thanks @BarnyShergold

@dobooth
Copy link
Contributor

dobooth commented Mar 9, 2021

@magento import code to magento-devdocs/devdocs

@dobooth dobooth added 2.4.x Magento 2.4.x related changes Technical Updates to the code or processes that alter the technical content of the doc labels Mar 9, 2021
@magento-engcom-team
Copy link

@dobooth the branch with code successfully imported intomagento-devdocs/devdocs repository. Branch name: imported-magento-devdocs-8762.

@magento-cicd2 magento-cicd2 merged commit 630477a into magento:master Mar 10, 2021
@ghost
Copy link

ghost commented Mar 10, 2021

Hi @Viper9x, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.4.x Magento 2.4.x related changes Progress: done Technical Updates to the code or processes that alter the technical content of the doc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants