Skip to content

Conversation

@oshmyheliuk
Copy link
Contributor

@oshmyheliuk oshmyheliuk commented Oct 1, 2020

Description

Added possibility to skip composer dump-autoload command by setting the SKIP_COMPOSER_DUMP_AUTOLOAD variable in .magento.env.yaml to true

build:
    SKIP_COMPOSER_DUMP_AUTOLOAD: true

Fixed Issues (if relevant)

https://jira.corp.magento.com/browse/MCLOUD-6939

Manual testing scenarios

  1. Set log level to debug in .magento.env.yaml
MIN_LOGGING_LEVEL: debug
  1. Set SKIP_COMPOSER_DUMP_AUTOLOAD variable to true:
stage:
   build:
    SKIP_COMPOSER_DUMP_AUTOLOAD: true
  1. Commit and push on the cloud, check that the composer dump-autoload command didn't run

Release notes

For user-facing changes, add a meaningful release note. For examples, see Magento Cloud ECE-tools release notes.

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful updates for any required release notes and documentation changes
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@NadiyaS
Copy link
Contributor

NadiyaS commented Oct 5, 2020

@magento import pr to magento-commerce/ece-tools

@magento-engcom-team
Copy link

@NadiyaS the pull request successfully imported.

@oshmyheliuk
Copy link
Contributor Author

@oshmyheliuk oshmyheliuk closed this Oct 5, 2020
@ghost
Copy link

ghost commented Oct 5, 2020

Hi @oshmyheliuk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants