Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Partial Response With NULL value #110

@roma-glushko

Description

@roma-glushko

Preconditions

  1. Magento 2 Open Source
  2. GraphQL modules

Steps to reproduce

  1. Execute GraphQL request that should return partial response

Expected result

  1. Response should contain errors and data keys.
  2. If item can be retrieved via GraphQL a new item to errors array is added, no NULL value is also added to data key

Actual result

  1. Response should contain errors and data keys.
  2. If item can be retrieved via GraphQL a new item to errors array is added, but null value is also added to data key

screen shot 2018-06-30 at 6 00 25 pm

Looks like this is a default GraphQL behaviour defined in vendor/webonyx/graphql-php/src/Executor/Executor.php:769 class. However, it's needed to consider if we can improve this point.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions