Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

GraphQL-296: SetBillingAddressOnCart #303

Closed
wants to merge 3 commits into from

Conversation

AleksLi
Copy link
Contributor

@AleksLi AleksLi commented Dec 20, 2018

Description

[Cart Operations] Set Billing Address.

Fixed Issues (if relevant)

  1. magento/graphql-ce#<296>: [Cart Operations] Set Billing Address

Manual testing scenarios (*)

  1. Setting billing address from existing or adding the new one.
mutation {
  setBillingAddressOnCart (
    input: {
      cart_id:"Wk1LVMo27tD9iqX99PvlHGE5cNGzOkyD",
    	billing_address: {
	        customer_address_id:3
      }
    }
  ) {
    cart {
     addresses {
        firstname
        lastname
        company
        street
        city
        postcode
        telephone
      }
    } 
  }
}

@AleksLi AleksLi force-pushed the 296-cart-set-billing-address branch from 61faa7e to a0dfb7b Compare December 22, 2018 07:09
self::assertArrayHasKey('cart', $response['setBillingAddressOnCart']);
$cartResponse = $response['setBillingAddressOnCart']['cart'];
self::assertArrayHasKey('addresses', $cartResponse);
// 'addresses' have shipping address and billing address. For this test shipping address is empty
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have 2 addresses all the time, and the first is always empty I guess we can skip the first element for this test.

@AleksLi
Copy link
Contributor Author

AleksLi commented Dec 22, 2018

Finished this PR for now. @rogyar and @keharper I'm starving for your REVIEW

@keharper
Copy link
Contributor

I approve the exception messages and description strings.

@AleksLi AleksLi force-pushed the 296-cart-set-billing-address branch from 34d779a to 17986f8 Compare January 28, 2019 21:17
@naydav
Copy link
Contributor

naydav commented Feb 19, 2019

Functionality was merged with #321

@naydav naydav closed this Feb 19, 2019
@ghost
Copy link

ghost commented Feb 19, 2019

Hi @AleksLi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@shrikant2jcommerce
Copy link

shrikant2jcommerce commented Feb 19, 2019 via email

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Feb 19, 2019 via email

@nilesh2jcommerce
Copy link

nilesh2jcommerce commented Feb 19, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 19, 2019 via email

@priti2jcommerce
Copy link
Contributor

priti2jcommerce commented Feb 19, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 19, 2019 via email

@ajay2jcommerce
Copy link

ajay2jcommerce commented Feb 19, 2019 via email

@dipti2jcommerce
Copy link

dipti2jcommerce commented Feb 19, 2019 via email

@ajay2jcommerce
Copy link

ajay2jcommerce commented Feb 19, 2019 via email

@shrikant2jcommerce
Copy link

shrikant2jcommerce commented Feb 19, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 19, 2019 via email

@dipti2jcommerce
Copy link

dipti2jcommerce commented Feb 19, 2019 via email

@nilesh2jcommerce
Copy link

nilesh2jcommerce commented Feb 19, 2019 via email

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Feb 19, 2019 via email

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Feb 19, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 19, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 19, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 19, 2019 via email

@ajay2jcommerce
Copy link

ajay2jcommerce commented Feb 19, 2019 via email

@priti2jcommerce
Copy link
Contributor

priti2jcommerce commented Feb 19, 2019 via email

@nilesh2jcommerce
Copy link

nilesh2jcommerce commented Feb 19, 2019 via email

@nilesh2jcommerce
Copy link

nilesh2jcommerce commented Feb 19, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 19, 2019 via email

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Feb 19, 2019 via email

@shrikant2jcommerce
Copy link

shrikant2jcommerce commented Feb 19, 2019 via email

@shrikant2jcommerce
Copy link

shrikant2jcommerce commented Feb 19, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 19, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 19, 2019 via email

@priti2jcommerce
Copy link
Contributor

priti2jcommerce commented Feb 19, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 19, 2019 via email

@priti2jcommerce
Copy link
Contributor

priti2jcommerce commented Feb 19, 2019 via email

@ajay2jcommerce
Copy link

ajay2jcommerce commented Feb 19, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 19, 2019 via email

@dipti2jcommerce
Copy link

dipti2jcommerce commented Feb 19, 2019 via email

@shrikant2jcommerce
Copy link

shrikant2jcommerce commented Feb 19, 2019 via email

@nilesh2jcommerce
Copy link

nilesh2jcommerce commented Feb 19, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 19, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 19, 2019 via email

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Feb 19, 2019 via email

@shrikant2jcommerce
Copy link

shrikant2jcommerce commented Feb 19, 2019 via email

@nilesh2jcommerce
Copy link

nilesh2jcommerce commented Feb 19, 2019 via email

@dipti2jcommerce
Copy link

dipti2jcommerce commented Feb 19, 2019 via email

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Feb 19, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 19, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 19, 2019 via email

@amol2jcommerce
Copy link
Contributor

amol2jcommerce commented Feb 19, 2019 via email

@lenaorobei lenaorobei deleted the 296-cart-set-billing-address branch September 10, 2019 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.