[326] Added The exclamation point to input type field for CustomerAddressInput schema

[RickyThakur]

Description (*)

The exclamation point ( "!" , field value can not be null, required field ) missing from the customer's mutation input type object arguments for the input CustomerAddressInput .

1. GraphQl uses '!' mark to promise that field can not return null value OR field is required
2. In graphql-ce/app/code/Magento/CustomerGraphQl/etc/schema.graphqls the CustomerAddressInput has following required fields

city: String
country_id: CountryCodeEnum
firstname: String
lastname: String
street: [String]
telephone: String

3. Error response for validation for CustomerAddressInputInput is being thrown by GraphQlInputException from resolver

"message": "Required parameters are missing: city, country_id, firstname, lastname, street, telephone",
 "category": "graphql-input",
  ......

• There should be '!' sign after the datatype declaration according to GraphQl syntax.

city: String!
country_id: CountryCodeEnum!

Fixed Issues (if relevant)

1. Fix for wrong coupon calculation. magento2#326: The exclamation point ( "!" , field value can not be null, required field ) missing from the customer's mutation input type object arguments for the input CustomerAddressInput

Manual testing scenarios (*)

Mutation for add customer address

mutation{
  createCustomerAddress(
  input: {
     /* intentionally did not provide the input fields to generate validation error */
    }
  ){
    city
    company
    country_id
    customer_id
    default_billing
    default_shipping
    fax
    firstname
    id
    lastname
    middlename
    postcode
    prefix
    region_id
    street
    suffix
    telephone
    vat_id
  }
}



Response

{
  "errors": [
    {
      "message": "Field CustomerAddressInput.city of required type String! was not provided.",
      "category": "graphql",
      "locations": [
        {
          "line": 8,
          "column": 10
        }
      ]
    },
    {
      "message": "Field CustomerAddressInput.country_id of required type CountryCodeEnum! was not provided.",
      "category": "graphql",
      "locations": [
        {
          "line": 8,
          "column": 10
        }
      ]
    },
    {
      "message": "Field CustomerAddressInput.firstname of required type String! was not provided.",
      "category": "graphql",
      "locations": [
        {
          "line": 8,
          "column": 10
        }
      ]
    },
    {
      "message": "Field CustomerAddressInput.lastname of required type String! was not provided.",
      "category": "graphql",
      "locations": [
        {
          "line": 8,
          "column": 10
        }
      ]
    },
    {
      "message": "Field CustomerAddressInput.street of required type [String]! was not provided.",
      "category": "graphql",
      "locations": [
        {
          "line": 8,
          "column": 10
        }
      ]
    },
    {
      "message": "Field CustomerAddressInput.telephone of required type String! was not provided.",
      "category": "graphql",
      "locations": [
        {
          "line": 8,
          "column": 10
        }
      ]
    }

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[paliarush]

This input type is used for createCustomerAddress as well as updateCustomerAddress where all these fields are not required.

[naydav]

Closed due to
#333 (review)

[ghost]

Hi @RickyThakur, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.