Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Added label from store view #346

Conversation

sergiy-v
Copy link

@sergiy-v sergiy-v commented Feb 6, 2019

Description (*)

PR for issue #250 Configurable Options Label doesn't return the Store View Label
This PR added functionality to show store label in label response

Fixed Issues (if relevant)

#250: Configurable Options Label doesn't return the Store View Label

Manual testing scenarios (*)

Request: Store Label "Custom Color", Default Store Label "Color"

{
  products(filter: { sku: { eq: "Test Configurable" } }) {
    items {
      name
      ... on ConfigurableProduct {
        configurable_options {
          attribute_code
          id
          label
        }
      }
    }
  }
}

Response:

{
  "data": {
    "products": {
      "items": [
        {
          "name": "Test Configurable",
          "configurable_options": [
            {
              "attribute_code": "color",
              "id": 35,
              "label": "Custom Color"
            }
          ]
        }
      ]
    }
  }
}

Response with empty Store Label

{
  "data": {
    "products": {
      "items": [
        {
          "name": "Test Configurable",
          "configurable_options": [
            {
              "attribute_code": "color",
              "id": 35,
              "label": "Color"
            }
          ]
        }
      ]
    }
  }
}

Also tested with different store and with branch 2.3-develop.
Api-functional test included.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 6, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team merged commit fd83649 into magento:2.3-develop Feb 11, 2019
@ghost
Copy link

ghost commented Feb 11, 2019

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants