customizable_options.values contains everything but value(s)

[XxXgeoXxX]

Description (*)

Original Issue: #698

according to the issue #474 and PR #525
The field 'value' was moved to 'CartItemSelectedOptionValuePrice'
I debugged and rechecked all product custom options and field 'value' is missed and always return NULL.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[naydav]

@TomashKhamlai
Could you check this case? Because it should not be null
https://github.com/magento/graphql-ce/blob/2.3-develop/app/code/Magento/QuoteGraphQl/Model/CartItem/DataProvider/CustomizableOptionValue/Text.php#L51
Thanks

[TomashKhamlai]

@naydav, value is null now.
The full response is:

{
  "data": {
    "addVirtualProductsToCart": {
      "cart": {
        "items": [
          {
            "id": "4",
            "quantity": 1,
            "customizable_options": [
              {
                "id": 1,
                "label": "Multiple",
                "values": [
                  {
                    "id": 6,
                    "value": null,
                    "label": "Opt-multiple-1"
                  },
                  {
                    "id": 6,
                    "value": null,
                    "label": "Opt-multiple-2"
                  }
                ]
              }
            ],
            "product": {
              "sku": "Virtual-Product-281557499732285-multiple"
            }
          }
        ]
      }
    }
  }
}

[XxXgeoXxX]

class app/code/Magento/QuoteGraphQl/Model/CartItem/DataProvider/CustomizableOptionValue/Multiple.php has missed param 'value' in returned data
@TomashKhamlai
Could you check?

[XxXgeoXxX]

@naydav
changes in schema.graphs were reverted
Tests for operation 'Add product with customizable options' have already existed.
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddSimpleProductWithCustomOptionsToCartTest.php
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/AddVirtualProductWithCustomOptionsToCartTest.php

[lenaorobei]

@XxXgeoXxX there might be some issues with tests if they didn't fail before the fix. Could you please re-check it. Thanks.

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-5496 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[ghost]

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.