This repository was archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 153
graphQl-702 Added test coverage for Customer Downloadable Products #779
Merged
magento-engcom-team
merged 6 commits into
magento:2.3-develop
from
vovsky:702-Test-coverage-Customer-Downloadable-Products
Jul 30, 2019
Merged
graphQl-702 Added test coverage for Customer Downloadable Products #779
magento-engcom-team
merged 6 commits into
magento:2.3-develop
from
vovsky:702-Test-coverage-Customer-Downloadable-Products
Jul 30, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenaorobei
suggested changes
Jul 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vovsky looks like redundant fixtures are used in some tests. Please consider revisiting these and addressing WebAPI Tests build
build failure. Thank you.
@lenaorobei checks have passed now. Thanks |
…thub.com:vovsky/graphql-ce into 702-Test-coverage-Customer-Downloadable-Products
@vovsky I meant slightly different thing and pushed it to your branch. |
lenaorobei
approved these changes
Jul 25, 2019
Hi @lenaorobei, thank you for the review. |
Hi @vovsky, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR adds api-functional tests for Customer Downloadable Products functionality
Fixed Issues (if relevant)