Skip to content
This repository was archived by the owner on Dec 19, 2019. It is now read-only.

Mark config fixtures as deprecated #800

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Mark config fixtures as deprecated #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1003ba
Mark config fixtures as deprecated
XxXgeoXxX Aug 1, 2019
dab77d2
Mark config fixtures as deprecated
XxXgeoXxX Aug 2, 2019
6513538
Mark config fixtures as deprecated
XxXgeoXxX Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...nctional/testsuite/Magento/GraphQl/AuthorizenetAcceptjs/Customer/SetPaymentMethodTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,15 @@ protected function setUp()
/**
* @magentoApiDataFixture Magento/Customer/_files/customer.php
* @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/enable_offline_shipping_methods.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/set_new_shipping_address.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/set_new_billing_address.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/set_flatrate_shipping_method.php
* @magentoApiDataFixture Magento/GraphQl/AuthorizenetAcceptjs/_files/enable_authorizenetacceptjs.php
* @magentoConfigFixture default_store carriers/flatrate/active 1
* @magentoConfigFixture default_store carriers/tablerate/active 1
* @magentoConfigFixture default_store carriers/freeshipping/active 1
* @param string $nonce
* @param string $descriptor
* @param bool $expectSuccess
Expand Down
4 changes: 3 additions & 1 deletion ...-functional/testsuite/Magento/GraphQl/AuthorizenetAcceptjs/Guest/SetPaymentMethodTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,16 @@ protected function setUp()

/**
* @magentoApiDataFixture Magento/GraphQl/Catalog/_files/simple_product.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/enable_offline_shipping_methods.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/guest/set_guest_email.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/set_new_shipping_address.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/set_new_billing_address.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/set_flatrate_shipping_method.php
* @magentoApiDataFixture Magento/GraphQl/AuthorizenetAcceptjs/_files/enable_authorizenetacceptjs.php
* @magentoConfigFixture default_store carriers/flatrate/active 1
* @magentoConfigFixture default_store carriers/tablerate/active 1
* @magentoConfigFixture default_store carriers/freeshipping/active 1
* @param string $nonce
* @param string $descriptor
* @param bool $expectSuccess
Expand Down
10 changes: 9 additions & 1 deletion ...integration/testsuite/Magento/GraphQl/Quote/_files/disable_all_active_payment_methods.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,15 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
// TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167
/**
* @deprecated use next @magentoConfigFixture instead:
* @magentoConfigFixture default_store payment/fake_vault/active 0
* @magentoConfigFixture default_store payment/paypal_billing_agreement/active 0
* @magentoConfigFixture default_store payment/fake/active 0
* @magentoConfigFixture default_store payment/checkmo/active 0
* @magentoConfigFixture default_store payment/free/active 0
*
*/
declare(strict_types=1);

use Magento\Config\Model\Config;
Expand Down
4 changes: 3 additions & 1 deletion ...on/testsuite/Magento/GraphQl/Quote/_files/disable_all_active_payment_methods_rollback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
// TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167
/**
* @deprecated use @magentoConfigFixture instead.
*/
declare(strict_types=1);

use Magento\Framework\App\Config\ScopeConfigInterface;
Expand Down
5 changes: 4 additions & 1 deletion dev/tests/integration/testsuite/Magento/GraphQl/Quote/_files/disable_guest_checkout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
// TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167
/**
* @deprecated use next @magentoConfigFixture instead:
* @magentoConfigFixture default_store checkout/options/guest_checkout 0
*/
declare(strict_types=1);

use Magento\Framework\App\Config\Storage\Writer;
Expand Down
4 changes: 3 additions & 1 deletion ...ts/integration/testsuite/Magento/GraphQl/Quote/_files/disable_guest_checkout_rollback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
// TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167
/**
* @deprecated use @magentoConfigFixture instead.
*/
declare(strict_types=1);

use Magento\Framework\App\Config\Storage\Writer;
Expand Down
7 changes: 6 additions & 1 deletion ...s/integration/testsuite/Magento/GraphQl/Quote/_files/disable_offline_shipping_methods.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
// TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167
/**
* @deprecated use next @magentoConfigFixture instead:
* @magentoConfigFixture default_store carriers/flatrate/active 0
* @magentoConfigFixture default_store carriers/tablerate/active 0
* @magentoConfigFixture default_store carriers/freeshipping/active 0
*/
declare(strict_types=1);

use Magento\Framework\App\Config\Storage\Writer;
Expand Down
4 changes: 3 additions & 1 deletion ...tion/testsuite/Magento/GraphQl/Quote/_files/disable_offline_shipping_methods_rollback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
// TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167
/**
* @deprecated use next @magentoConfigFixture instead.
*/
declare(strict_types=1);

use Magento\Framework\App\Config\Storage\Writer;
Expand Down
9 changes: 8 additions & 1 deletion ...sts/integration/testsuite/Magento/GraphQl/Quote/_files/enable_offline_payment_methods.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
// TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167
/**
* @deprecated use next @magentoConfigFixture instead:
* @magentoConfigFixture default_store payment/banktransfer/active 1
* @magentoConfigFixture default_store payment/cashondelivery/active 1
* @magentoConfigFixture default_store payment/checkmo/active 1
* @magentoConfigFixture default_store payment/purchaseorder/active 1
* @magentoConfigFixture default_store payment/authorizenet_acceptjs/active 1
*/
declare(strict_types=1);

use Magento\Framework\App\Config\Storage\Writer;
Expand Down
4 changes: 3 additions & 1 deletion ...ration/testsuite/Magento/GraphQl/Quote/_files/enable_offline_payment_methods_rollback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
// TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167
/**
* @deprecated use @magentoConfigFixture instead.
*/
declare(strict_types=1);

use Magento\Framework\App\Config\Storage\Writer;
Expand Down
7 changes: 6 additions & 1 deletion ...ts/integration/testsuite/Magento/GraphQl/Quote/_files/enable_offline_shipping_methods.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@
* Copyright © Magento, Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the use of this file in \Magento\GraphQl\AuthorizenetAcceptjs\Customer\SetPaymentMethodTest::testPlaceOrder. It needs to be replaced with @magentoConfigFixture.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* See COPYING.txt for license details.
*/
// TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167
/**
* @deprecated use next @magentoConfigFixture instead:
* @magentoConfigFixture default_store carriers/flatrate/active 1
* @magentoConfigFixture default_store carriers/tablerate/active 1
* @magentoConfigFixture default_store carriers/freeshipping/active 1
*/
declare(strict_types=1);

use Magento\Framework\App\Config\Storage\Writer;
Expand Down
4 changes: 3 additions & 1 deletion ...ation/testsuite/Magento/GraphQl/Quote/_files/enable_offline_shipping_methods_rollback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
// TODO: Should be removed in scope of https://github.com/magento/graphql-ce/issues/167
/**
* @deprecated use @magentoConfigFixture instead.
*/
declare(strict_types=1);

use Magento\Framework\App\Config\Storage\Writer;
Expand Down