graphQl-961: ShippingAddressInput.postcode: String, is not required by Schema

[kisroman]

Description (*)

Fixed Issues (if relevant)

1. ShippingAddressInput.postcode: String, is not required by Schema #961

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[lenaorobei]

We do not care about BC in GraphQL modules. Only the schema is out API.
https://github.com/magento/graphql-ce/wiki/Approach-to-Implementation#backward-compatibility-policy

[kisroman]

Ok.

[lenaorobei]

Please add also test case with multiple errors.

[kisroman]

Done.

[lenaorobei]

Please address comments.

[lenaorobei]

@TomashKhamlai query you are trying to test has syntax issues. shipping_addresses should be array.

shipping_addresses: [
        {
          address: {
            street: ["Streer"]
            country_code: "US"
            firstname: "John"
            lastname: "Doubledo"
            telephone: ""
            save_in_address_book: true
            city: "Culver city"
          }
        }
      ]

[lenaorobei]

@magento run Functional Tests

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-6170 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[TomashKhamlai]

@lenaorobei, I've tried with array syntax also (usually both variants work as expected)

Request:

mutation {
  setShippingAddressesOnCart(
    input: {
      cart_id: "02GYdVCktyqGo8LfEkoBwPbkCLxt3lL9"
      shipping_addresses: [
        {
          address: {
            country_code: "US"
            firstname: "John"
            lastname: "Doubledo"
            telephone: ""
            save_in_address_book: true
            city: "Culver city"
          }
        }
      ]
    }
  ) {
    cart {
      email
      shipping_addresses {
        postcode
        firstname
        lastname
        telephone
        selected_shipping_method {
          carrier_code
          method_code
        }
        available_shipping_methods {
          carrier_code
          method_code
        }
      }
    }
  }
}

Response:

{
  "errors": [
    {
      "debugMessage": "Notice: Undefined index: street in /var/www/html/graphqlce/app/code/Magento/QuoteGraphQl/Model/Cart/QuoteAddressFactory.php on line 93",
      "message": "Internal server error",
      "extensions": {
        "category": "internal"
      },
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "setShippingAddressesOnCart"
      ]
    }
  ],
  "data": {
    "setShippingAddressesOnCart": null
  }
}

[TomashKhamlai]

I think that $addressInput['street'] can be empty and this should be checked here or somewhere else before these lines can be executed.

[lenaorobei]

@magento run Unit Tests

[TomashKhamlai]

Created a separate issue #1033 for the case when the street parameter was omitted.

[ghost]

Hi @kisroman, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.