You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As we are going to deliver all the changes brought in the scope of MSI into Magento CE magento/magento2#13434
to guarantee modularity of MSI and prove that Magento CE 2.3 could still work with disabled MSI
we need to adapt Product Import in CE version and provide an implementation for interface
namespace Magento\CatalogImportExport\Model;
/**
* Interface StockItemImporterInterface
*
* @api
*/
interface StockItemImporterInterface
{
/**
* Handle Import of Stock Item Data
*
* @param array $stockData
* @return void
*/
public function import(array $stockData);
}
which currently exists just in MSI. So, CE will fatal without MSI on board.
Proposed implementation details:
The most interesting place we need to fix is:
We need to import in both cases (Legacy and MSI) the same SourceItems
For legacy we need more fields (configuration), but MSI needs just Qty and Stock Status.
Business logic should look like : $this->stockItemImporter->import($stockData);
and implementation of Importer Interface in CE
can resolve a table for insertion by its own, no need to pass it from the calling code
like this:
As we are going to deliver all the changes brought in the scope of MSI into Magento CE magento/magento2#13434
to guarantee modularity of MSI and prove that Magento CE 2.3 could still work with disabled MSI
we need to adapt Product Import in CE version and provide an implementation for interface
which currently exists just in MSI. So, CE will fatal without MSI on board.
Proposed implementation details:
The most interesting place we need to fix is:
We need to import in both cases (Legacy and MSI) the same SourceItems
For legacy we need more fields (configuration), but MSI needs just Qty and Stock Status.
Business logic should look like :
$this->stockItemImporter->import($stockData);
and implementation of Importer Interface in CE
can resolve a table for insertion by its own, no need to pass it from the calling code
like this:
and MSI will pluginize call to
StockItemImporterInterface::import(array $stockData)
extract needed data out of
$stockData
because we no need configuration which is stored in$stockData
and proceed with current logic
doing so, we will make :
The text was updated successfully, but these errors were encountered: