Quote items qty validation tests on default and not default stocks #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-520-is-product-salable-integration-test' of https://github.com/magento-engcom/msi into msi-520-is-product-salable-integration-test
…//github.com/magento-engcom/msi into msi-520-is-product-salable-integration-test
VitaliyBoyko
changed the title
… no way to decrease dependencies more.
naydav
reviewed
Mar 13, 2018
| private function getProductBySku(string $sku): ProductInterface | ||
| { | ||
| $product = $this->productRepository->get($sku); | ||
| $product->setIsSalable(true); |
There was a problem hiding this comment.
You don't need to set is_sallable flag forcible
If product has wrong status it is a bug
# Conflicts: # app/code/Magento/InventoryConfigurableProduct/etc/di.xml
MSI: 664: Generate products window during creating Configurable products empty
MSI: 654: Exception when trying to create Grouped or Bundle product in admin
…rrectQtyCondition
…com:magento-engcom/msi into msi-520-is-product-salable-integration-test
…torySalesApi on InventorySales
…i-520-is-product-salable-integration-test' of https://github.com/magento-engcom/msi into msi-520-is-product-salable-integration-test # Conflicts: # app/code/Magento/InventorySales/etc/di.xml
…e-for-requested-qty Add IsProductSalableForRequestedQty service
maghamed
changed the base branch from
msi-520-is-product-salable-for-requested-qty
to
msi_393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrational tests for check whether a customer can buy or put into Shopping Cart needed an amount of product