Skip to content

Conversation

@oshmyheliuk
Copy link
Contributor

@oshmyheliuk oshmyheliuk commented Aug 21, 2020

Description

https://jira.corp.magento.com/browse/MCLOUD-2789
Added functionality for installing custom elastic search plugins.

Manual testing scenarios

https://studio.cucumber.io/projects/210147/test-plan/folders/1564670/scenarios/5121522

  1. Build elasticsearch image:
docker build -t test/es:latest ../magento-cloud-docker/images/elasticsearch/7.7
  1. Create docker-compose.override.yaml file
version: "2.1"

services:
    elasticsearch:
        image: 'test/es:latest'
  1. Add some custom plugins in .magento/services.yaml, for example:
elasticsearch:
    type: elasticsearch:7.7
    disk: 1024
    configuration:
        plugins:
            - analysis-icu
            - analysis-phonetic
            - analysis-stempel
            - analysis-nori
  1. Run command for generating docker-compose.yaml
vendor/bin/ece-docker build:compose
  1. Open docker-compose.yaml file and check that elasticsearch service contains:
    environment:
      - 'ES_PLUGINS=analysis-stempel analysis-nori'

P.S. analysis-icu and analysis-phonetic are skipped as they installed by default.

  1. Run docker-compose up -d
  2. Run docker-compose logs elasticsearch and check that added plugin was installed.
elasticsearch_1  | Intalling plugins:
elasticsearch_1  | -> Installing analysis-stempel
elasticsearch_1  | -> Downloading analysis-stempel from elastic
elasticsearch_1  | -> Installed analysis-stempel
elasticsearch_1  | -> Installing analysis-nori
elasticsearch_1  | -> Downloading analysis-nori from elastic
elasticsearch_1  | -> Installed analysis-nori
  1. Repeat with different elasticsearch version >= 6.5

Release notes

Added support to use the Elasticsearch plugin configuration information from the services.yaml file to generate the docker-compose.yaml file for a Cloud Docker environment.

Associated documentation updates

magento/devdocs#7898

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful release notes and documentation
  • All commits are accompanied by meaningful commit messages

@oshmyheliuk oshmyheliuk requested a review from NadiyaS August 23, 2020 04:34
@andriyShevtsov andriyShevtsov self-assigned this Aug 24, 2020
@m2-community-project m2-community-project bot added the Progress: review PR/issue status label Aug 24, 2020
@andriyShevtsov andriyShevtsov removed their assignment Aug 24, 2020
@m2-community-project m2-community-project bot removed the Progress: review PR/issue status label Aug 24, 2020
* @var array
*/
private $versionMap = [
'6.5' => [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we support more earlier versions as we do on cloud?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They already reached EOL, I don't think we still need to add new features to old deprecated versions.

@mveeramneni
Copy link

QA Approved

@meker12
Copy link
Contributor

meker12 commented Sep 21, 2020

@oshmyheliuk Remember to add the release notes and documentation PR to the PR description when applicable. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants