MCLOUD-6430: Xdebug not working on Magento Cloud Docker 1.1 #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NadiyaS
reviewed
Aug 28, 2020
| * Include Xdebug if --with-xdebug is set | ||
| */ | ||
| if ($config->hasServiceEnabled(ServiceInterface::SERVICE_FPM_XDEBUG)) { | ||
| $envVariables = ['PHP_EXTENSIONS' => implode(' ', array_unique(array_merge($phpExtensions, ['xdebug'])))]; |
Contributor
There was a problem hiding this comment.
why do you merge with xdebug here? Should not it be in the config already?
Contributor
Author
There was a problem hiding this comment.
Because this configuration only for fpm_xdebug container and it needs to have enabled xdebug extension.
$phpExtensions may not have xdebug if it not set-up in .magento.app.yaml
NadiyaS
approved these changes
Aug 31, 2020
shiftedreality
suggested changes
Aug 31, 2020
| [ ! -z "${MAGENTO_RUN_MODE}" ] && sed -i "s/!MAGENTO_RUN_MODE!/${MAGENTO_RUN_MODE}/" /usr/local/etc/php-fpm.conf | ||
|
|
||
| # Set host.docker.inernal for LINUX os | ||
| if [[ "$SET_DOCKER_HOST" = "true" ]]; then |
Member
There was a problem hiding this comment.
Can we have it enabled by default?
Contributor
Author
There was a problem hiding this comment.
Why do we need it by default? This option has a sense only for Linux system.
Also I tested it on macOS with generated host.docker.inernal and xdebug didn't work.
shiftedreality
approved these changes
Aug 31, 2020
mveeramneni
added
Progress: testing in progress
and removed
Progress: review
|
Tested in MacOS and it's working fine. @BaDos is testing in his virual box |
arhiopterecs
approved these changes
Sep 2, 2020
Contributor
|
Tested on my linux machine, it works. |
m2-community-project
bot
added
Progress: done
and removed
Progress: testing in progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed issue with not working xdebug.
Fixed Issues (if relevant)
Manual testing scenarios
magento-cloud2.3.5 templatehttps://devdocs.magento.com/cloud/docker/docker-development-debug.html
build:composecommand with additional option--set-docker-hosthttps://devdocs.magento.com/cloud/docker/docker-development-debug.html
Release notes
Added the
--set-docker-hostoption to theece-docker build:composecommand to configure the host.docker.internal name in the fpm:xdebug container. On Linux systems, this option is required to use Xdebug in the Docker development environment.Associated documentation updates
Add link to Magento DevDocs PR or Issue, if needed.
Contribution checklist