Skip to content

[New Rule] Implement sniff for classes and interfaces PHPDoc formatting #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenaorobei opened this issue May 31, 2019 · 2 comments
Closed

[New Rule] Implement sniff for classes and interfaces PHPDoc formatting #105

lenaorobei opened this issue May 31, 2019 · 2 comments
Labels
accepted New rule is accepted new rule New feature implementation Progress: good first issue Issues is easy to get started with

Comments

@lenaorobei
Copy link
Contributor

lenaorobei commented May 31, 2019 •
edited
Loading

Rule

PHPDoc formatting for classes and interfaces.

Acceptance Criteria:

Classes and interfaces should have a short description that is a human-understandable intention of the class.
If the short description adds no additional information beyond what the type name already supplies, the short description must be omitted.

  • Rule covered by unit test.
<severity>5</severity>
<type>warning</type>
@lenaorobei lenaorobei added enhancement Improvements to existing rules accepted New rule is accepted new rule New feature implementation Progress: good first issue Issues is easy to get started with and removed enhancement Improvements to existing rules labels May 31, 2019
@lenaorobei lenaorobei mentioned this issue May 31, 2019
Merged
@lenaorobei lenaorobei changed the title [New Rule] Implement sniff for class PHPDoc formatting [New Rule] Implement sniff for classes and interfaces PHPDoc formatting May 31, 2019
@lenaorobei
Copy link
Contributor Author

Hi @udovicic! How is your progress with this ticket? Do you need any help?

@udovicic
Copy link
Member

udovicic commented Aug 1, 2019

Hi @lenaorobei , help no, but more hours in one day definitely. I think I will be done be the end of the week.

udovicic added a commit to udovicic/magento-coding-standard that referenced this issue Aug 3, 2019
@udovicic
Implement rule from magento#105
4c9e12a
@udovicic udovicic mentioned this issue Aug 3, 2019
Merged
udovicic added a commit to udovicic/magento-coding-standard that referenced this issue Aug 3, 2019
@udovicic
Implement rule from magento#105
36960e4
@lenaorobei lenaorobei mentioned this issue Aug 7, 2019
Closed
udovicic added a commit to udovicic/magento-coding-standard that referenced this issue Aug 7, 2019
@udovicic
Implement rule from magento#105
952f950
udovicic added a commit to udovicic/magento-coding-standard that referenced this issue Aug 10, 2019
@udovicic
Implement rule from magento#105
3d3f491
udovicic added a commit to udovicic/magento-coding-standard that referenced this issue Aug 10, 2019
@udovicic
Implement rule from magento#105
a439463
lenaorobei added a commit to udovicic/magento-coding-standard that referenced this issue Aug 12, 2019
@lenaorobei
Merge branch 'develop' into feature/magento#105-class-and-interface-d…
d17442f 
…ocblock-sniff
lenaorobei added a commit that referenced this issue Aug 12, 2019
@lenaorobei
Merge pull request #124 from udovicic/feature/#105-class-and-interfac…
2960287 
…e-docblock-sniff

Implement rule from #105
magento-devops-reposync-svc pushed a commit that referenced this issue Oct 27, 2021
@sivaschenko
Merge pull request #105 from magento-commerce/update-from-public
2c9a24a 
Update from public repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted New rule is accepted new rule New feature implementation Progress: good first issue Issues is easy to get started with
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@udovicic @lenaorobei